Commit 5f3c8ef

committed

Add PartialEq and PartialOrd impls for comparing String and &String

This makes such comparisons more robust against the availability of other impls.

1 parent 96492ea commit 5f3c8efCopy full SHA for 5f3c8ef

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2531,6 +2531,7 @@ macro_rules! impl_eq {`
`2531`	`2531`
`2532`	`2532`	`impl_eq! { String, str }`
`2533`	`2533`	`impl_eq! { String, &'a str }`
	`2534`	`+impl_eq! { String, &String }`
`2534`	`2535`	`impl_eq! { &String, str }`
`2535`	`2536`	`#[cfg(not(no_global_oom_handling))]`
`2536`	`2537`	`impl_eq! { Cow<'a, str>, str }`
`@@ -2566,6 +2567,7 @@ macro_rules! impl_ord {`
`2566`	`2567`	`impl_ord! { String, str }`
`2567`	`2568`	`impl_ord! { String, &'a str }`
`2568`	`2569`	`impl_ord! { &String, str }`
	`2570`	`+impl_ord! { String, &String }`
`2569`	`2571`	`#[cfg(not(no_global_oom_handling))]`
`2570`	`2572`	`impl_ord! { Cow<'a, str>, str }`
`2571`	`2573`	`#[cfg(not(no_global_oom_handling))]`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ pub fn get_clippy_rules_in_order(all_args: &[String], config: &LintConfig) -> Ve`
`77`	`77`	`let rule = format!("{prefix}{v}");`
`78`	`78`	`// Arguments added by bootstrap in LintConfig won't show up in the all_args list, so`
`79`	`79`	`// put them at the end of the command line.`
`80`		`- let position = all_args.iter().position(\|t\| t == &rule \|\| t == v).unwrap_or(usize::MAX);`
	`80`	`+ let position =`
	`81`	`+ all_args.iter().position(\|t\| t == rule.as_str() \|\| t == v).unwrap_or(usize::MAX);`
`81`	`82`	`result.push((position, rule));`
`82`	`83`	`});`
`83`	`84`	`}`

Comments

(0)