Commit 4fd600d

folkertdevtraviscross

and

authored

Apply suggestions from code review

Co-authored-by: Travis Cross <tc@traviscross.com>

1 parent 428ef41 commit 4fd600dCopy full SHA for 4fd600d

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ impl<'gcc, 'tcx> StaticCodegenMethods for CodegenCx<'gcc, 'tcx> {`
`82`	`82`	`global.to_rvalue().set_type(val_llty);`
`83`	`83`	`}`
`84`	`84`
`85`		`- // NOTE: alignment from attributes has already been applied to the allocation.`
	`85`	`+ // NOTE: Alignment from attributes has already been applied to the allocation.`
`86`	`86`	`set_global_alignment(self, global, alloc.align);`
`87`	`87`
`88`	`88`	`global.global_set_initializer_rvalue(value);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,7 @@ impl<'ll> CodegenCx<'ll, '_> {`
`453`	`453`	`new_g`
`454`	`454`	`};`
`455`	`455`
`456`		`- // NOTE: alignment from attributes has already been applied to the allocation.`
	`456`	`+ // NOTE: Alignment from attributes has already been applied to the allocation.`
`457`	`457`	`set_global_alignment(self, g, alloc.align);`
`458`	`458`	`llvm::set_initializer(g, v);`
`459`	`459`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -953,7 +953,7 @@ impl<'tcx, M: Machine<'tcx>> InterpCx<'tcx, M> {`
`953`	`953`
`954`	`954`	`// # Global allocations`
`955`	`955`	`if let Some(global_alloc) = self.tcx.try_get_global_alloc(id) {`
`956`		`- // NOTE: static alignment from attributes has already been applied to the allocation.`
	`956`	+ // NOTE: `static` alignment from attributes has already been applied to the allocation.
`957`	`957`	`let (size, align) = global_alloc.size_and_align(*self.tcx, self.typing_env);`
`958`	`958`	`let mutbl = global_alloc.mutability(*self.tcx, self.typing_env);`
`959`	`959`	`let kind = match global_alloc {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ declare_features! (`
`632`	`632`	`(unstable, simd_ffi, "1.0.0", Some(27731)),`
`633`	`633`	`/// Allows specialization of implementations (RFC 1210).`
`634`	`634`	`(incomplete, specialization, "1.7.0", Some(31844)),`
`635`		- /// Allows using `#[rustc_align_static(...)]` on static items
	`635`	+ /// Allows using `#[rustc_align_static(...)]` on static items.
`636`	`636`	`(unstable, static_align, "CURRENT_RUSTC_VERSION", Some(146177)),`
`637`	`637`	`/// Allows attributes on expressions and non-item statements.`
`638`	`638`	`(unstable, stmt_expr_attributes, "1.6.0", Some(15701)),`

Comments

(0)