Commit 07de7a4

committed

Pre-intern name when searching module children

This avoids a good deal of work, since each module child can now just be compared via u32 comparison, rather than fetching the raw &str (requiring locking and indexing into the interner) and then comparing the two strings (also relatively expensive).

1 parent ccbfe50 commit 07de7a4Copy full SHA for 07de7a4

File tree

1 file changed

-1

lines changed

src/tools/miri/src
- helpers.rs

1 file changed

-1

lines changed

`‎src/tools/miri/src/helpers.rs‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,10 @@ fn try_resolve_did(tcx: TyCtxt<'_>, path: &[&str], namespace: Option<Namespace>)`
`38`	`38`	`item: DefId,`
`39`	`39`	`name: &'a str,`
`40`	`40`	`) -> impl Iterator<Item = DefId> + 'a {`
	`41`	`+ let name = Symbol::intern(name);`
`41`	`42`	`tcx.module_children(item)`
`42`	`43`	`.iter()`
`43`		`- .filter(move \|item\| item.ident.name.as_str() == name)`
	`44`	`+ .filter(move \|item\| item.ident.name == name)`
`44`	`45`	`.map(move \|item\| item.res.def_id())`
`45`	`46`	`}`
`46`	`47`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 07de7a4

File tree

1 file changed

1 file changed

`‎src/tools/miri/src/helpers.rs‎`

0 commit comments