Commit 01f0caf

committed

Perform check_private_in_public by module.

1 parent a2320b2 commit 01f0cafCopy full SHA for 01f0caf

File tree

+10

-5

lines changed

+10

-5

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1147,7 +1147,9 @@ fn analysis(tcx: TyCtxt<'_>, (): ()) {`
`1147`	`1147`
`1148`	`1148`	`parallel!(`
`1149`	`1149`	`{`
`1150`		`- tcx.ensure_ok().check_private_in_public(());`
	`1150`	`+ tcx.par_hir_for_each_module(\|module\| {`
	`1151`	`+ tcx.ensure_ok().check_private_in_public(module)`
	`1152`	`+ })`
`1151`	`1153`	`},`
`1152`	`1154`	`{`
`1153`	`1155`	`tcx.par_hir_for_each_module(\|module\| {`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1390,8 +1390,11 @@ rustc_queries! {`
`1390`	`1390`	`eval_always`
`1391`	`1391`	`desc { "checking effective visibilities" }`
`1392`	`1392`	`}`
`1393`		`- query check_private_in_public(_: ()) {`
`1394`		`- desc { "checking for private elements in public interfaces" }`
	`1393`	`+ query check_private_in_public(module_def_id: LocalModDefId) {`
	`1394`	`+ desc { \|tcx\|`
	`1395`	`+ "checking for private elements in public interfaces for {}",`
	`1396`	`+ describe_as_module(module_def_id, tcx)`
	`1397`	`+ }`
`1395`	`1398`	`}`
`1396`	`1399`
`1397`	`1400`	`query reachable_set(_: ()) -> &'tcx LocalDefIdSet {`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1854,12 +1854,12 @@ fn effective_visibilities(tcx: TyCtxt<'_>, (): ()) -> &EffectiveVisibilities {`
`1854`	`1854`	`tcx.arena.alloc(visitor.effective_visibilities)`
`1855`	`1855`	`}`
`1856`	`1856`
`1857`		`-fn check_private_in_public(tcx: TyCtxt<'_>, ():()) {`
	`1857`	`+fn check_private_in_public(tcx: TyCtxt<'_>, module_def_id:LocalModDefId) {`
`1858`	`1858`	`let effective_visibilities = tcx.effective_visibilities(());`
`1859`	`1859`	`// Check for private types in public interfaces.`
`1860`	`1860`	`let mut checker = PrivateItemsInPublicInterfacesChecker { tcx, effective_visibilities };`
`1861`	`1861`
`1862`		`- let crate_items = tcx.hir_crate_items(());`
	`1862`	`+ let crate_items = tcx.hir_module_items(module_def_id);`
`1863`	`1863`	`for id in crate_items.free_items() {`
`1864`	`1864`	`checker.check_item(id);`
`1865`	`1865`	`}`

Comments

(0)