This repository was archived by the owner on May 28, 2025. It is now read-only.

Commit 23e040a

committed

Auto merge of rust-lang#125426 - jieyouxu:rmake-support-env-reset, r=saethlin

Update `compiler-builtins` test to not clear essential env vars Noticed in rust-lang#122580 (comment), the `compiler-builtins` test failed on Windows for a `cargo` invocation because necessary env vars `TMP` and `TEMP` were cleared by `Command::env_clear`, causing temp dir eventually used by codegen to fallback to the Windows directory, which will trigger permission errors. This PR removes the `env_clear` on the cargo invocation. r? `@saethlin` (feel free to reroll, since you authored the test) try-job: x86_64-msvc try-job: test-various

2 parents 44701e0 + 2949195 commit 23e040aCopy full SHA for 23e040a

File tree

1 file changed

-1

lines changed

tests/run-make/compiler-builtins
- rmake.rs

1 file changed

-1

lines changed

`‎tests/run-make/compiler-builtins/rmake.rs‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ fn main() {`
`56`	`56`	`"--target",`
`57`	`57`	`&target,`
`58`	`58`	`])`
`59`		`- .env_clear()`
`60`	`59`	`.env("PATH", path)`
`61`	`60`	`.env("RUSTC", rustc)`
`62`	`61`	`.env("RUSTFLAGS", "-Copt-level=0 -Cdebug-assertions=yes")`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 23e040a

File tree

1 file changed

1 file changed

`‎tests/run-make/compiler-builtins/rmake.rs‎`

0 commit comments