Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Future maintenance of this package #238

Closed
@Emilios1995

Description

I acknowledge and am deeply grateful for the work @nkrkv put into this parser.

However, it hasn't been updated for a long time, even with multiple PRs open. I think that rescript deserves proper support in Neovim and other modern editors, and I also think there's enough members of the community that care about this; we just need to get organized. With the advent of newer editors such as Zed and Helix, this module will become even more important.

It would be ideal to form a group of maintainers, get the repo into a stable state, and pitch the Rescript lang maintainers to move this parser into the rescript-lang umbrella GitHub org. Then, we should bundle the parser info into the official Neovim tree-sitter module so that folks can simply TSInstall rescript

I took the liberty of merging many of the currently open PRs into my own fork as a starting point, but again, the goal is to get it under the umbrella organization.

As a disclaimer, I'm by no means a tree-sitter expert, but I care enough about the problem to help out. For example, I'm still not sure why it's necessary to handle newlines in the external scanner instead of relaying on the default lexing flow with the correct precedence rules (among other questions). But even if we need a refactor, it would be good to get into a stable shape first.

So, what do you all think? How do you feel about the overall state of this parser? Could it be refactored and simplified? Would you like to help maintain and move the repo to the rescript-lang org?

Of course @nkrkv, if you still mean to maintain this and are just on a temporary hiatus, please let us know.

CC @aspeddro @cristianoc @zweimach @TheFedaikin

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /