Commit 82d5195

committed

Revert "Use execFile instead of exec to fix Windows path issue (#59)"

This reverts commit 115fa1d.

1 parent c4c5a36 commit 82d5195Copy full SHA for 82d5195

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ let createProject = async (~templateName, ~projectName, ~versions) => {`
`69`	`69`	`await updateRescriptJson(~projectName, ~versions)`
`70`	`70`
`71`	`71`	`await RescriptVersions.installVersions(versions)`
`72`		`- let _ = await Promisified.ChildProcess.execFile("git", ["init"])`
	`72`	`+ let _ = await Promisified.ChildProcess.exec("gitinit")`
`73`	`73`
`74`	`74`	`if !CI.isRunningInCI {`
`75`	`75`	`s->P.Spinner.stop("Project created.")`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,9 @@ let promptVersions = async () => {`
`66`	`66`	`let installVersions = async ({rescriptVersion, rescriptCoreVersion}) => {`
`67`	`67`	`let packageManager = PackageManagers.getActivePackageManager()`
`68`	`68`	let packages = [`rescript@${rescriptVersion}`, `@rescript/core@${rescriptCoreVersion}`]
	`69`	+ let command = `${packageManager} add ${packages->Array.join(" ")}`
`69`	`70`
`70`		`- let _ = await Node.Promisified.ChildProcess.execFile(packageManager, ["add", ...packages])`
	`71`	`+ let _ = await Node.Promisified.ChildProcess.exec(command)`
`71`	`72`	`}`
`72`	`73`
`73`	`74`	`let esmModuleSystemName = ({rescriptVersion}) =>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,6 @@ module Promisified = {`
`85`	`85`	`type execResult = {stdout: string, stderr: string}`
`86`	`86`
`87`	`87`	`@module("./NodePromisified.mjs")`
`88`		`- external execFile: (string, array<string>) => promise<execResult> = "execFile"`
	`88`	`+ external exec: string=> promise<execResult> = "exec"`
`89`	`89`	`}`
`90`	`90`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { execFile as execFileCallback } from "child_process";`
	`1`	`+import { exec as execCallback } from "child_process";`
`2`	`2`	`import { promisify } from "util";`
`3`	`3`
`4`		`-export const execFile = promisify(execFileCallback);`
	`4`	`+export const exec = promisify(execCallback);`

Comments

(0)