Commit 115fa1d

authored

Use execFile instead of exec to fix Windows path issue (#59)

1 parent d25ba3a commit 115fa1dCopy full SHA for 115fa1d

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ let createNewProject = async () => {`
`81`	`81`	`await updateRescriptJson(~projectName, ~versions)`
`82`	`82`
`83`	`83`	`await RescriptVersions.installVersions(versions)`
`84`		`- let _ = await Promisified.ChildProcess.exec("gitinit")`
	`84`	`+ let _ = await Promisified.ChildProcess.execFile("git", ["init"])`
`85`	`85`
`86`	`86`	`s->P.Spinner.stop("Project created.")`
`87`	`87`	`}`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,8 @@ let promptVersions = async () => {`
`66`	`66`	`let installVersions = async ({rescriptVersion, rescriptCoreVersion}) => {`
`67`	`67`	`let packageManager = PackageManagers.getActivePackageManager()`
`68`	`68`	let packages = [`rescript@${rescriptVersion}`, `@rescript/core@${rescriptCoreVersion}`]
`69`		- let command = `${packageManager} add ${packages->Array.join(" ")}`
`70`	`69`
`71`		`- let _ = await Node.Promisified.ChildProcess.exec(command)`
	`70`	`+ let _ = await Node.Promisified.ChildProcess.execFile(packageManager, ["add", ...packages])`
`72`	`71`	`}`
`73`	`72`
`74`	`73`	`let esmModuleSystemName = ({rescriptVersion}) =>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,6 @@ module Promisified = {`
`85`	`85`	`type execResult = {stdout: string, stderr: string}`
`86`	`86`
`87`	`87`	`@module("./NodePromisified.mjs")`
`88`		`- external exec: string=> promise<execResult> = "exec"`
	`88`	`+ external execFile: (string, array<string>) => promise<execResult> = "execFile"`
`89`	`89`	`}`
`90`	`90`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { exec as execCallback } from "child_process";`
	`1`	`+import { execFile as execFileCallback } from "child_process";`
`2`	`2`	`import { promisify } from "util";`
`3`	`3`
`4`		`-export const exec = promisify(execCallback);`
	`4`	`+export const execFile = promisify(execFileCallback);`

Comments

(0)