Commit 0d0cfe6

authored

Redis Search/Aggregate improved type annotations (#3676)

* Fix ft.aggregate variable arguments type annotation * Fix ft.aggregate query type annotation

1 parent cc5f129 commit 0d0cfe6Copy full SHA for 0d0cfe6

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class Reducer:`
`26`	`26`
`27`	`27`	`NAME = None`
`28`	`28`
`29`		`- def __init__(self, *args: List[str]) -> None:`
	`29`	`+ def __init__(self, *args: str) -> None:`
`30`	`30`	`self._args = args`
`31`	`31`	`self._field = None`
`32`	`32`	`self._alias = None`
`@@ -116,7 +116,7 @@ def __init__(self, query: str = "*") -> None:`
`116`	`116`	`self._add_scores = False`
`117`	`117`	`self._scorer = "TFIDF"`
`118`	`118`
`119`		`- def load(self, *fields: List[str]) -> "AggregateRequest":`
	`119`	`+ def load(self, *fields: str) -> "AggregateRequest":`
`120`	`120`	`"""`
`121`	`121`	`Indicate the fields to be returned in the response. These fields are`
`122`	`122`	`returned in addition to any others implicitly specified.`
`@@ -223,7 +223,7 @@ def limit(self, offset: int, num: int) -> "AggregateRequest":`
`223`	`223`	`self._aggregateplan.extend(_limit.build_args())`
`224`	`224`	`return self`
`225`	`225`
`226`		`- def sort_by(self, fields: List[str], *kwargs) -> "AggregateRequest":`
	`226`	`+ def sort_by(self, fields: str, *kwargs) -> "AggregateRequest":`
`227`	`227`	`"""`
`228`	`228`	`Indicate how the results should be sorted. This can also be used for`
`229`	`229`	`top-N style queries`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -542,7 +542,7 @@ def explain_cli(self, query: Union[str, Query]): # noqa`
`542`	`542`
`543`	`543`	`def aggregate(`
`544`	`544`	`self,`
`545`		`- query: Union[str, Query],`
	`545`	`+ query: Union[AggregateRequest, Cursor],`
`546`	`546`	`query_params: Dict[str, Union[str, int, float]] = None,`
`547`	`547`	`):`
`548`	`548`	`"""`
`@@ -573,7 +573,7 @@ def aggregate(`
`573`	`573`	`)`
`574`	`574`
`575`	`575`	`def _get_aggregate_result(`
`576`		`- self, raw: List, query: Union[str, Query, AggregateRequest], has_cursor: bool`
	`576`	`+ self, raw: List, query: Union[AggregateRequest, Cursor], has_cursor: bool`
`577`	`577`	`):`
`578`	`578`	`if has_cursor:`
`579`	`579`	`if isinstance(query, Cursor):`
`@@ -967,7 +967,7 @@ async def search(`
`967`	`967`
`968`	`968`	`async def aggregate(`
`969`	`969`	`self,`
`970`		`- query: Union[str, Query],`
	`970`	`+ query: Union[AggregateResult, Cursor],`
`971`	`971`	`query_params: Dict[str, Union[str, int, float]] = None,`
`972`	`972`	`):`
`973`	`973`	`"""`

Comments

(0)