Commit 445a56d

ianschmitzTimer

authored and

committed

Fix TypeScript decorator support (#5783)

* Fix TypeScript decorator support * Update babel flow override * WIP

1 parent 2c92fd4 commit 445a56dCopy full SHA for 445a56d

File tree

+29

-1

lines changed

+29

-1

lines changed

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,13 @@ module.exports = function(api, opts, env) {`
`113`	`113`	`// Strip flow types before any other transform, emulating the behavior`
`114`	`114`	`// order as-if the browser supported all of the succeeding features`
`115`	`115`	`// https://github.com/facebook/create-react-app/pull/5182`
`116`		`- isFlowEnabled &&`
	`116`	`+ // We will conditionally enable this plugin below in overrides as it clashes with`
	`117`	`+ // @babel/plugin-proposal-decorators when using TypeScript.`
	`118`	`+ // https://github.com/facebook/create-react-app/issues/5741`
	`119`	`+ isFlowEnabled && [`
`117`	`120`	`require('@babel/plugin-transform-flow-strip-types').default,`
	`121`	`+ false,`
	`122`	`+ ],`
`118`	`123`	`// Experimental macros support. Will be documented after it's had some time`
`119`	`124`	`// in the wild.`
`120`	`125`	`require('babel-plugin-macros'),`
`@@ -177,6 +182,10 @@ module.exports = function(api, opts, env) {`
`177`	`182`	`require('babel-plugin-dynamic-import-node'),`
`178`	`183`	`].filter(Boolean),`
`179`	`184`	`overrides: [`
	`185`	`+ isFlowEnabled && {`
	`186`	`+ exclude: /\.tsx?$/,`
	`187`	`+ plugins: [require('@babel/plugin-transform-flow-strip-types').default],`
	`188`	`+ },`
`180`	`189`	`isTypeScriptEnabled && {`
`181`	`190`	`test: /\.tsx?$/,`
`182`	`191`	`plugins: [`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,3 +6,9 @@ it('reads a typescript file with no syntax error', () => {`
`6`	`6`	`expect(App.foo.baz!.n).toBe(123);`
`7`	`7`	`expect(app.n).toBe(123);`
`8`	`8`	`});`
	`9`	`+`
	`10`	`+it('supports decorators', () => {`
	`11`	`+ const app = new App();`
	`12`	`+ expect((app as any).annotated).toBe(true);`
	`13`	`+ expect(app.decorated).toBe(42);`
	`14`	`+});`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,10 +10,23 @@ type MyObject = Pick<MyType, 'bar' \| 'baz'>;`
`10`	`10`	`class App {`
`11`	`11`	`static foo: MyObject = { bar: true, baz: { n: 123 } };`
`12`	`12`	`n = App.foo.baz!.n;`
	`13`	`+ @propertyDecorator`
	`14`	`+ decorated;`
`13`	`15`	`}`
`14`	`16`
`15`	`17`	`function annotation(target: any) {`
`16`	`18`	`target.annotated = true;`
`17`	`19`	`}`
`18`	`20`
	`21`	`+function propertyDecorator(target: any, key: string) {`
	`22`	`+ if (delete target[key]) {`
	`23`	`+ Object.defineProperty(target, key, {`
	`24`	`+ get() {`
	`25`	`+ return 42;`
	`26`	`+ },`
	`27`	`+ enumerable: true,`
	`28`	`+ });`
	`29`	`+ }`
	`30`	`+}`
	`31`	`+`
`19`	`32`	`export default App;`

Comments

(0)