Commit 3190e4f

authored

Handle service worker error in Firefox (#8272)

* Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js

1 parent 0299c0e commit 3190e4fCopy full SHA for 3190e4f

File tree

+14

-6

lines changed

packages
- cra-template-typescript/template/src
  - serviceWorker.ts
- cra-template/template/src
  - serviceWorker.js

+14

-6

lines changed

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -138,8 +138,12 @@ function checkValidServiceWorker(swUrl: string, config?: Config) {`
`138`	`138`
`139`	`139`	`export function unregister() {`
`140`	`140`	`if ('serviceWorker' in navigator) {`
`141`		`- navigator.serviceWorker.ready.then(registration => {`
`142`		`- registration.unregister();`
`143`		`- });`
	`141`	`+ navigator.serviceWorker.ready`
	`142`	`+ .then(registration => {`
	`143`	`+ registration.unregister();`
	`144`	`+ })`
	`145`	`+ .catch(error => {`
	`146`	`+ console.error(error.message);`
	`147`	`+ });`
`144`	`148`	`}`
`145`	`149`	`}`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,12 @@ function checkValidServiceWorker(swUrl, config) {`
`130`	`130`
`131`	`131`	`export function unregister() {`
`132`	`132`	`if ('serviceWorker' in navigator) {`
`133`		`- navigator.serviceWorker.ready.then(registration => {`
`134`		`- registration.unregister();`
`135`		`- });`
	`133`	`+ navigator.serviceWorker.ready`
	`134`	`+ .then(registration => {`
	`135`	`+ registration.unregister();`
	`136`	`+ })`
	`137`	`+ .catch(error => {`
	`138`	`+ console.error(error.message);`
	`139`	`+ });`
`136`	`140`	`}`
`137`	`141`	`}`

Comments

(0)