Commit 2fdfda0

committed

Merge pull request #120 from taion/child-onClick

Call onClick on child as well

2 parents f911799 + b1fbbab commit 2fdfda0Copy full SHA for 2fdfda0

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,10 @@ export default class LinkContainer extends React.Component {`
`16`	`16`	`return;`
`17`	`17`	`}`
`18`	`18`
	`19`	`+ if (this.props.children.props.onClick) {`
	`20`	`+ this.props.children.props.onClick(event);`
	`21`	`+ }`
	`22`	`+`
`19`	`23`	`Link.prototype.handleClick.call(this, event);`
`20`	`24`	`}`
`21`	`25`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,14 +104,15 @@ describe('LinkContainer', () => {`
`104`	`104`	`expect(target).to.exist;`
`105`	`105`	`});`
`106`	`106`
`107`		`- it('should call a user defined click handler', () => {`
	`107`	`+ it('should call user defined click handlers', () => {`
`108`	`108`	`const onClick = sinon.spy();`
	`109`	`+ const childOnClick = sinon.spy();`
`109`	`110`
`110`	`111`	`class LinkWrapper extends React.Component {`
`111`	`112`	`render() {`
`112`	`113`	`return (`
`113`	`114`	`<LinkContainer to="/foo" onClick={onClick}>`
`114`		`- <Component>Foo</Component>`
	`115`	`+ <ComponentonClick={childOnClick}>Foo</Component>`
`115`	`116`	`</LinkContainer>`
`116`	`117`	`);`
`117`	`118`	`}`
`@@ -128,7 +129,8 @@ describe('LinkContainer', () => {`
`128`	`129`	`);`
`129`	`130`	`ReactTestUtils.Simulate.click(ReactDOM.findDOMNode(component));`
`130`	`131`
`131`		`- expect(onClick).to.have.been.called;`
	`132`	`+ expect(onClick).to.have.been.calledOnce;`
	`133`	`+ expect(childOnClick).to.have.been.calledOnce;`
`132`	`134`	`});`
`133`	`135`	`});`
`134`	`136`

Comments

(0)