Commit 5625194

authored

Fix has_only_digits.py

The previous code only counted how many characters where in the string and then compared to its length, always returning True, it didn't matter if it had letters or not. I'm proposing this code as a solution to the problem.

1 parent a6331e3 commit 5625194Copy full SHA for 5625194

File tree

1 file changed

+11

-13

lines changed

has_only_digits.py

1 file changed

+11

-13

lines changed

`‎has_only_digits.py‎`

Lines changed: 11 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,16 @@`
`1`		`-# Given a string, check if it only contains digits`
	`1`	`+# Given a string, check if it only contains digits.`
`2`	`2`
`3`	`3`	`def is_digit(input_str):`
`4`		`- digits = dict()`
`5`		`-`
`6`		`- for char in input_str:`
`7`		`- if char in digits:`
`8`		`- digits[char] += 1`
`9`		`- else:`
`10`		`- digits[char] = 1`
`11`		`-`
`12`		`- if sum(digits.values()) == len(input_str):`
`13`		`- return True`
`14`		`- else:`
`15`		`- return False`
	`4`	`+ try:`
	`5`	`+ # If its possible to convert to a number, return True.`
	`6`	`+ int(input_str)`
	`7`	`+ return True`
	`8`	`+ except ValueError:`
	`9`	`+ # If the string contains letters, above will fail, returning False.`
	`10`	`+ return False`
`16`	`11`
`17`	`12`	`result = is_digit("095357973590759530")`
`18`	`13`	`print(result) # True`
	`14`	`+`
	`15`	`+result = is_digit("1234abc567")`
	`16`	`+print(result) # False`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 5625194

File tree

1 file changed

1 file changed

`‎has_only_digits.py‎`

0 commit comments