-
Notifications
You must be signed in to change notification settings - Fork 114
Starting Address record line is always the first line, but in original file it was last line #43
Description
I am testing this module for some production/testing firmware automation and I am super pleased!
I am noticing that when I encode a hex file to a dict with this module, then fetch and re-save to a hex file (the data is stored in a database as a JSON record) one line gets swapped in the file thus causing my md5 checksums to not match. While I am fairly certain the structure of an intel hex file prevents this from being an issue, it would be nice to under stand how this happens.
Encode to database:
file_name = file_path.split('/')[-1]
with open(file_path, 'rb') as file:
md5 = hashlib.md5(
file.read()
).hexdigest()
intel_hex = IntelHex()
intel_hex.loadhex(file_path)
if image_type.lower() in ['mfg', 'manufacturing']:
self.manufacturing_fw = intel_hex.todict()
self.manufacturing_fw_name = file_name
self.manufacturing_md5 = md5
Decode From database:
if image_type.lower() in ['mfg', 'manufacturing']:
output_file_name = f'{out_path}/{self.part_number}-{self.manufacturing_fw_name}'
firmware_data = self.manufacturing_fw
data = {}
for key, value in firmware_data.items():
if key != 'start_addr':
key = int(key)
data[key] = value
intel_hex = IntelHex()
intel_hex.fromdict(data)
intel_hex.write_hex_file(output_file_name)
I need to add these lines upon export to re-arrange the lines to get the exported file to match the original exactly.
Not efficient or the minimum solution, but it works with everything I have tested so far.
file = open(output_file_name, 'r')
lines = file.readlines()
file.close()
output = open(output_file_name, 'w')
total_lines = len(lines)
last_line = lines[-1]
lines.append(lines[-1])
lines[0], lines[total_lines-1] = lines[total_lines-1], lines[0]
lines.append(last_line)
for line in lines[1:-1]:
output.write(line)
output.close()
I appreciate any help with this!