-
Notifications
You must be signed in to change notification settings - Fork 45
Open
@vxgmichel
Description
At the moment, the wsproto.typing.Header type is not compatible with h11._headers.Header which is defined as the following, starting with version 0.13.0:
class Headers(Sequence[Tuple[bytes, bytes]]): [...]
The following patch might provide this compatibility:
diff --git a/src/wsproto/typing.py b/src/wsproto/typing.py index a44b27e..1786501 100644 --- a/src/wsproto/typing.py +++ b/src/wsproto/typing.py @@ -1,3 +1,3 @@ -from typing import List, Tuple +from typing import Sequence, Tuple -Headers = List[Tuple[bytes, bytes]] +Headers = Sequence[Tuple[bytes, bytes]]
This would fix mypy errors such as:
error: Argument "headers" to "initiate_upgrade_connection" of "WSConnection" has incompatible type "Headers"; expected "List[Tuple[bytes, bytes]]" [arg-type]
Would that make sense? I can make a PR if necessary.
Metadata
Metadata
Assignees
Labels
No labels