Commit 8c30416

author

programmiri

committed

Apply feedback from exercism for excercise Space Age

1 parent 46d772f commit 8c30416Copy full SHA for 8c30416

File tree

-6

lines changed

-6

lines changed

Lines changed: 5 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,6 @@`
`1`		`-const planetMap = {`
	`1`	`+const BASE_SECONDS = 31557600;`
	`2`	`+`
	`3`	`+const PLANET_MAP = {`
`2`	`4`	`earth: 1,`
`3`	`5`	`mercury: 0.2408467,`
`4`	`6`	`venus: 0.61519726,`
`@@ -9,12 +11,9 @@ const planetMap = {`
`9`	`11`	`neptune: 164.79132,`
`10`	`12`	`};`
`11`	`13`
`12`		`-function roundFloat(float, dec) {`
`13`		`- return +Number.parseFloat(float).toFixed(dec);`
`14`		`-}`
	`14`	`+const roundFloat = (float, dec) => Number(float.toFixed(dec));`
`15`	`15`
`16`	`16`	`export const age = (planet, seconds) => {`
`17`		`- const baseSeconds = 31557600;`
`18`		`- const yearsNonRounded = seconds / (baseSeconds * planetMap[planet]);`
	`17`	`+ const yearsNonRounded = seconds / (BASE_SECONDS * PLANET_MAP[planet]);`
`19`	`18`	`return roundFloat(yearsNonRounded, 2);`
`20`	`19`	`};`

Comments

(0)