Commit 41e6324

committed

Using MODULES for building .so instead of MODULE_big.

This is fix of my previous commit 1443ae0. PGXS supports two ways of building shared libraries: building an so for each module specified in MODULES and building one big so named MODULE_big for all modules specified in OBJS. Previously this extension used the latter, but also specified MODULES variable for no reason, which is pretty strange. Since extension contains just one module, it is sane to use the former. I have removed OBJS variable, but forgot to remove MODULE_big in my previous commit, which broke the build, since an empty so was assembled. This commit fixes the issue. Besides, PG_CONFIG var is now consulted for path to pg_config, which allows to build extension without pg_config in the PATH.

1 parent 8158b1a commit 41e6324Copy full SHA for 41e6324

File tree

1 file changed

-3

lines changed

Makefile

1 file changed

-3

lines changed

`‎Makefile‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,13 @@`
`1`	`1`	`EXTENSION = zson`
`2`	`2`	`MODULES = zson`
`3`	`3`	`DATA = zson--1.1.sql zson--1.0--1.1.sql`
`4`		`-OBJS = zson.o`
`5`	`4`	`REGRESS = zson`
`6`	`5`
`7`		`-MODULE_big = zson`
`8`	`6`	`PG_CPPFLAGS = -g -O2`
`9`	`7`	`SHLIB_LINK = # -lz -llz4`
`10`	`8`
`11`		`-PGXS := $(shell pg_config --pgxs)`
	`9`	`+ifndef PG_CONFIG`
	`10`	`+ PG_CONFIG := pg_config`
	`11`	`+endif`
	`12`	`+PGXS := $(shell $(PG_CONFIG) --pgxs)`
`12`	`13`	`include $(PGXS)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 41e6324

File tree

1 file changed

1 file changed

`‎Makefile‎`

0 commit comments