Commit 2062ab9

committed

[PGPRO-5255] fix that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate ERROR instead of NOTICE

1 parent 6b484c2 commit 2062ab9Copy full SHA for 2062ab9

File tree

+17

-1

lines changed

+17

-1

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -370,4 +370,11 @@ SELECT create_hash_partitions('drop_index.test', 'val', 2);`
`370`	`370`	`DROP INDEX CONCURRENTLY drop_index.test_0_val_idx;`
`371`	`371`	`DROP SCHEMA drop_index CASCADE;`
`372`	`372`	`NOTICE: drop cascades to 3 other objects`
	`373`	`+/*`
	`374`	`+ * Test, that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate NOTICE instead of ERROR`
	`375`	`+ */`
	`376`	`+CREATE SCHEMA rename_nonexistent;`
	`377`	`+ALTER TABLE IF EXISTS rename_nonexistent.nonexistent_table RENAME TO other_table_name;`
	`378`	`+NOTICE: relation "nonexistent_table" does not exist, skipping`
	`379`	`+DROP SCHEMA rename_nonexistent CASCADE;`
`373`	`380`	`DROP EXTENSION pg_pathman;`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -250,6 +250,12 @@ DROP INDEX CONCURRENTLY drop_index.test_0_val_idx;`
`250`	`250`
`251`	`251`	`DROP SCHEMA drop_index CASCADE;`
`252`	`252`
	`253`	`+/*`
	`254`	`+ * Test, that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate NOTICE instead of ERROR`
	`255`	`+ */`
	`256`	`+CREATE SCHEMA rename_nonexistent;`
	`257`	`+ALTER TABLE IF EXISTS rename_nonexistent.nonexistent_table RENAME TO other_table_name;`
	`258`	`+DROP SCHEMA rename_nonexistent CASCADE;`
`253`	`259`
`254`	`260`
`255`	`261`	`DROP EXTENSION pg_pathman;`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,10 @@ is_pathman_related_table_rename(Node *parsetree,`
`175`	`175`	`/* Fetch Oid of this relation */`
`176`	`176`	`relation_oid = RangeVarGetRelid(rename_stmt->relation,`
`177`	`177`	`AccessShareLock,`
`178`		`- false);`
	`178`	`+ rename_stmt->missing_ok);`
	`179`	`+ /* PGPRO-5255: check ALTER TABLE IF EXISTS of non existent table */`
	`180`	`+ if (rename_stmt->missing_ok && relation_oid == InvalidOid)`
	`181`	`+ return false;`
`179`	`182`
`180`	`183`	`/* Assume it's a parent */`
`181`	`184`	`if (has_pathman_relation_info(relation_oid))`

Comments

(0)