Commit 7e8685f

committed

Support link in logo

1 parent ca4c4e6 commit 7e8685fCopy full SHA for 7e8685f

File tree

2 files changed

+10

-5

lines changed

src
- DefaultEditor.js
- components/widgets
  - Logo.js

2 files changed

+10

-5

lines changed

`‎src/DefaultEditor.js‎`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -78,11 +78,12 @@ class DefaultEditor extends Component {`
`78`	`78`
`79`	`79`	`render() {`
`80`	`80`	`const _ = this.context.localize;`
`81`		`- const logo = this.props.logoSrc && <Logo src={this.props.logoSrc} />;`
	`81`	`+ const {logoSrc, logoLinkUrl, menuPanelOrder, children} = this.props;`
	`82`	`+ const logo = logoSrc && <Logo src={logoSrc} link={logoLinkUrl} />;`
`82`	`83`
`83`	`84`	`return (`
`84`		`- <PanelMenuWrapper menuPanelOrder={this.props.menuPanelOrder}>`
`85`		`- {logo ? logo : null}`
	`85`	`+ <PanelMenuWrapper menuPanelOrder={menuPanelOrder}>`
	`86`	`+ {logo \|\| null}`
`86`	`87`	`<GraphCreatePanel group={_('Structure')} name={_('Traces')} />`
`87`	`88`	`<GraphSubplotsPanel group={_('Structure')} name={_('Subplots')} />`
`88`	`89`	`{this.hasTransforms() && (`
`@@ -99,7 +100,7 @@ class DefaultEditor extends Component {`
`99`	`100`	`<StyleImagesPanel group={_('Annotate')} name={_('Images')} />`
`100`	`101`	`{this.hasSliders() && <StyleSlidersPanel group={_('Control')} name={_('Sliders')} />}`
`101`	`102`	`{this.hasMenus() && <StyleUpdateMenusPanel group={_('Control')} name={_('Menus')} />}`
`102`		`- {this.props.children ? this.props.children : null}`
	`103`	`+ {children \|\| null}`
`103`	`104`	`</PanelMenuWrapper>`
`104`	`105`	`);`
`105`	`106`	`}`
`@@ -108,6 +109,7 @@ class DefaultEditor extends Component {`
`108`	`109`	`DefaultEditor.propTypes = {`
`109`	`110`	`children: PropTypes.node,`
`110`	`111`	`logoSrc: PropTypes.string,`
	`112`	`+ logoLinkUrl: PropTypes.string,`
`111`	`113`	`menuPanelOrder: PropTypes.array,`
`112`	`114`	`};`
`113`	`115`

`‎src/components/widgets/Logo.js‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,12 +3,15 @@ import React, {Component} from 'react';`
`3`	`3`
`4`	`4`	`export default class Logo extends Component {`
`5`	`5`	`render() {`
`6`		`- return <img className="sidebar__logo" src={this.props.src} />;`
	`6`	`+ const {link, src} = this.props;`
	`7`	`+ const image = <img className="sidebar__logo" src={src} />;`
	`8`	`+ return link ? <a href={this.props.link}>{image}</a> : image;`
`7`	`9`	`}`
`8`	`10`	`}`
`9`	`11`
`10`	`12`	`Logo.plotly_editor_traits = {sidebar_element: true};`
`11`	`13`
`12`	`14`	`Logo.propTypes = {`
`13`	`15`	`src: PropTypes.string,`
	`16`	`+ link: PropTypes.string,`
`14`	`17`	`};`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 7e8685f

File tree

2 files changed

2 files changed

`‎src/DefaultEditor.js‎`

`‎src/components/widgets/Logo.js‎`

0 commit comments