Commit 4ba788c

committed

fix: minor updates based on feedback from @emilykl

1 parent 12cd7a6 commit 4ba788cCopy full SHA for 4ba788c

File tree

6 files changed

+22

-12

lines changed

.circleci
- config.yml
CONTRIBUTING.md
pyproject.toml
tests
- test_core/test_figure_widget_backend
  - test_missing_anywidget.py
- test_io
  - test_html.py
uv.lock

6 files changed

+22

-12

lines changed

`‎.circleci/config.yml‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ commands:`
`25`	`25`	`curl -LsSf https://astral.sh/uv/install.sh \| sh`
`26`	`26`	`uv venv`
`27`	`27`	`source .venv/bin/activate`
	`28`	`+ uv lock --check`
`28`	`29`	`uv sync --extra dev_core`
`29`	`30`	`- run:`
`30`	`31`	`name: List installed packages and python version`
`@@ -122,7 +123,7 @@ commands:`
`122`	`123`	`curl -LsSf https://astral.sh/uv/install.sh \| sh`
`123`	`124`	`uv venv`
`124`	`125`	`source .venv/bin/activate`
`125`		`- uv pip install .[dev_optional]`
	`126`	`+ uv sync --extra dev_optional`
`126`	`127`	`# Install Kaleido v0 instead of the v1 specified in requirements_optional.txt`
`127`	`128`	`uv pip uninstall kaleido`
`128`	`129`	`uv pip install kaleido==0.2.1`

`‎CONTRIBUTING.md‎`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -109,10 +109,12 @@ If you are using `uv`,
`109`	`109`	`you can install all of the packages needed for developing and testing plotly.py with this command:`
`110`	`110`
`111`	`111`	```bash
`112`		`-uv pip install -e '.[dev]'`
	`112`	`+uv sync --extra dev`
`113`	`113`	```
`114`	`114`
`115`		-If you are using `conda` or `virtualenv`, you can install all packages with:
	`115`	+If you are using `conda` or `virtualenv`,
	`116`	+or if `uv sync` does not work as you expect,
	`117`	`+you can install all packages with:`
`116`	`118`
`117`	`119`	```bash
`118`	`120`	`pip install -e '.[dev]'`
`@@ -150,6 +152,11 @@ Once you have made your changes and tested them,`
`150`	`152`	`push your changes to your fork of the plotly.py repository on GitHub`
`151`	`153`	`and create your pull request.`
`152`	`154`
	`155`	+> Managing `uv.lock`
	`156`	`+>`
	`157`	+> Please do _not_ commit changes to `uv.lock`
	`158`	+> unless you have added, removed, or changed dependencies in `pyproject.toml`.
	`159`	`+`
`153`	`160`	`### Testing`
`154`	`161`
`155`	`162`	`We use [pytest](https://docs.pytest.org/) for managing and running tests.`

`‎pyproject.toml‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,6 @@ dependencies = [`
`42`	`42`	`express = ["numpy"]`
`43`	`43`	`kaleido = ["kaleido==1.0.0rc15"]`
`44`	`44`	`dev_core = [`
`45`		`- "anywidget",`
`46`	`45`	`"pytest",`
`47`	`46`	`"requests",`
`48`	`47`	`# pin precise version of ruff to prevent accidental reformatting in case its defaults are updated`
`@@ -56,6 +55,7 @@ dev_build = [`
`56`	`55`	`dev_optional = [`
`57`	`56`	`"plotly[dev_build]",`
`58`	`57`	`"plotly[kaleido]",`
	`58`	`+ "anywidget",`
`59`	`59`	`"colorcet",`
`60`	`60`	`# fiona>1.9.6 is not compatible with geopandas<1; geopandas>=1 is not compatible with python 3.8`
`61`	`61`	`"fiona<=1.9.6;python_version<='3.8'",`
`@@ -101,6 +101,7 @@ plotly = [`
`101`	`101`	`"package_data/*",`
`102`	`102`	`"package_data/templates/*",`
`103`	`103`	`"package_data/datasets/*",`
	`104`	`+ "validators/_validators.json"`
`104`	`105`	`]`
`105`	`106`
`106`	`107`	`[tool.jupyter-packaging.builder]`

`‎tests/test_core/test_figure_widget_backend/test_missing_anywidget.py‎`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,13 @@`
	`1`	`+# ruff: noqa: F401 F403 F405`
	`2`	`+`
`1`	`3`	`import pytest`
`2`	`4`
`3`	`5`	`# Use wildcard import to make sure FigureWidget is always included`
`4`		`-from plotly.graph_objects import FigureWidget`
	`6`	`+from plotly.graph_objects import *`
	`7`	`+from plotly.missing_anywidget import FigureWidget as FigureWidgetMissingAnywidget`
`5`	`8`
`6`	`9`	`try:`
`7`		`- fromplotly.missing_anywidgetimport FigureWidget as FigureWidgetMissingAnywidget`
	`10`	`+ import anywidget as _anywidget`
`8`	`11`
`9`	`12`	`missing_anywidget = False`
`10`	`13`	`except Exception:`

`‎tests/test_io/test_html.py‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,6 @@ def test_cdn_integrity_hash_matches_bundled_content(fig1):`
`68`	`68`	`expected_hash = _generate_sri_hash(plotlyjs_content)`
`69`	`69`
`70`	`70`	`# Verify they match`
`71`		`- assert (`
`72`		`- extracted_hash==expected_hash`
`73`		`- ), f"Hash mismatch: expected {expected_hash}, got {extracted_hash}"`
	`71`	`+ assert extracted_hash==expected_hash, (`
	`72`	`+ f"Hash mismatch: expected {expected_hash}, got {extracted_hash}"`
	`73`	`+ )`

`‎uv.lock‎`

Lines changed: 1 addition & 3 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 4ba788c

File tree

6 files changed

6 files changed

`‎.circleci/config.yml‎`

`‎CONTRIBUTING.md‎`

`‎pyproject.toml‎`

`‎tests/test_core/test_figure_widget_backend/test_missing_anywidget.py‎`

`‎tests/test_io/test_html.py‎`

`‎uv.lock‎`

0 commit comments