Commit e8434c8

committed

Enhance createGraphDiv function to accept a customizable divId parameter and update tests to utilize the new functionality.

1 parent bc80967 commit e8434c8Copy full SHA for e8434c8

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`'use strict';`
`2`	`2`
`3`		`-module.exports = function createGraphDiv() {`
	`3`	`+module.exports = function createGraphDiv(divId='graph') {`
`4`	`4`	`var gd = document.createElement('div');`
`5`		`- gd.id = 'graph';`
	`5`	`+ gd.id = divId;`
`6`	`6`	`document.body.appendChild(gd);`
`7`	`7`
`8`	`8`	`// force the graph to be at position 0,0 no matter what`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ var Lib = require('../../../src/lib');`
`8`	`8`	`var rgb = require('../../../src/components/color').rgb;`
`9`	`9`
`10`	`10`	`var createGraphDiv = require('../assets/create_graph_div');`
`11`		`-var createShadowGraphDiv = require('../assets/create_shadow_graph_div');`
`12`	`11`	`var destroyGraphDiv = require('../assets/destroy_graph_div');`
`13`	`12`	`var mouseEvent = require('../assets/mouse_event');`
`14`	`13`
`@@ -984,7 +983,7 @@ describe('Title automargining', function() {`
`984`	`983`
`985`	`984`	`it('computes title automargins independently when multiple plots exist', function(done) {`
`986`	`985`	`var gd1 = gd;`
`987`		`- var gd2 = createShadowGraphDiv();`
	`986`	`+ var gd2 = createGraphDiv('title-automargining-2');`
`988`	`987`
`989`	`988`	`var dataLocal = [{x: [1, 2], y: [1, 2]}];`
`990`	`989`
`@@ -1020,6 +1019,9 @@ describe('Title automargining', function() {`
`1020`	`1019`	`var t2 = gd2._fullLayout._size.t;`
`1021`	`1020`
`1022`	`1021`	`expect(t1).toBeGreaterThan(t2);`
	`1022`	`+ }).then(function() {`
	`1023`	`+ var el = document.getElementById('title-automargining-2');`
	`1024`	`+ if(el) document.body.removeChild(el);`
`1023`	`1025`	`})`
`1024`	`1026`	`.then(done, done.fail);`
`1025`	`1027`	`});`

Comments

(0)