Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 373d4ff

Browse files
authored
Merge pull request #5415 from plotly/no-v2-changes
update comments about v2 changes that moved to another major
2 parents 15d7cda + adbac02 commit 373d4ff

File tree

18 files changed

+24
-24
lines changed

18 files changed

+24
-24
lines changed

‎src/components/annotations/click.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ function getToggleSets(gd, hoverData) {
130130
return {on: onSet, off: offSet, explicitOff: explicitOffSet};
131131
}
132132

133-
// to handle log axes until v2
133+
// to handle log axes until v3
134134
function clickData2r(d, ax) {
135135
return ax.type === 'log' ? ax.l2r(d) : ax.d2r(d);
136136
}

‎src/components/annotations/convert_coords.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var toLogRange = require('../../lib/to_log_range');
1616
* convertCoords: when converting an axis between log and linear
1717
* you need to alter any annotations on that axis to keep them
1818
* pointing at the same data point.
19-
* In v2.0 this will become obsolete
19+
* In v3.0 this will become obsolete
2020
*
2121
* gd: the plot div
2222
* ax: the axis being changed

‎src/components/colorscale/helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ var letterAttrs = ['min', 'max', 'mid', 'auto'];
5050
/**
5151
* Extract 'c' / 'z', trace / color axis colorscale options
5252
*
53-
* Note that it would be nice to replace all z* with c* equivalents in v2
53+
* Note that it would be nice to replace all z* with c* equivalents in v3
5454
*
5555
* @param {object} cont : attribute container
5656
* @return {object}:

‎src/components/images/convert_coords.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var toLogRange = require('../../lib/to_log_range');
1616
* convertCoords: when converting an axis between log and linear
1717
* you need to alter any images on that axis to keep them
1818
* pointing at the same data point.
19-
* In v2.0 this will become obsolete (or perhaps size will still need conversion?)
19+
* In v3.0 this will become obsolete (or perhaps size will still need conversion?)
2020
* we convert size by declaring that the maximum extent *in data units* should be
2121
* the same, assuming the image is anchored by its center (could remove that restriction
2222
* if we think it's important) even though the actual left and right values will not be

‎src/components/legend/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ module.exports = function legendDefaults(layoutIn, layoutOut, fullData) {
9999
} else {
100100
// maybe use y=1.1 / yanchor=bottom as above
101101
// to avoid https://github.com/plotly/plotly.js/issues/1199
102-
// in v2
102+
// in v3
103103
defaultY = -0.1;
104104
defaultYAnchor = 'top';
105105
}

‎src/components/shapes/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function handleShapeDefaults(shapeIn, shapeOut, fullLayout) {
8181
var dflt0 = 0.25;
8282
var dflt1 = 0.75;
8383

84-
// hack until V2.0 when log has regular range behavior - make it look like other
84+
// hack until V3.0 when log has regular range behavior - make it look like other
8585
// ranges to send to coerce, then put it back after
8686
// this is all to give reasonable default position behavior on log axes, which is
8787
// a pretty unimportant edge case so we could just ignore this.

‎src/components/shapes/helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var Lib = require('../../lib');
1818
// so these have to be specified in terms of the category serial numbers,
1919
// but can take fractional values. Other axis types we specify position based on
2020
// the actual data values.
21-
// TODO: in V2.0 (when log axis ranges are in data units) range and shape position
21+
// TODO: in V3.0 (when log axis ranges are in data units) range and shape position
2222
// will be identical, so rangeToShapePosition and shapePositionToRange can be
2323
// removed entirely.
2424

‎src/plot_api/plot_config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ var configAttributes = {
126126
dflt: false,
127127
description: [
128128
'Determines whether to change the layout size when window is resized.',
129-
'In v2, this option will be removed and will always be true.'
129+
'In v3, this option will be removed and will always be true.'
130130
].join(' ')
131131
},
132132
fillFrame: {

‎src/plots/cartesian/helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
var strTranslate = require('../../lib').strTranslate;
1313

14-
// in v2 (once log ranges are fixed),
14+
// in v3 (once log ranges are fixed),
1515
// we'll be able to p2r here for all axis types
1616
function p2r(ax, v) {
1717
switch(ax.type) {

‎src/plots/cartesian/select.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,9 +355,9 @@ function prepSelect(e, startX, startY, dragOptions, mode) {
355355
}
356356

357357
if(clickmode === 'event') {
358-
// TODO: remove in v2 - this was probably never intended to work as it does,
358+
// TODO: remove in v3 - this was probably never intended to work as it does,
359359
// but in case anyone depends on it we don't want to break it now.
360-
// Note that click-to-select introduced pre v2 also emitts proper
360+
// Note that click-to-select introduced pre v3 also emitts proper
361361
// event data when clickmode is having 'select' in its flag list.
362362
gd.emit('plotly_selected', undefined);
363363
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /