Commit dc6455f

authored

Isolate names(...) in event_data() to prevent spurious updates (#2339)

* Isolate names(session$userData$plotlyInputStore) to prevent spurious updates (#2337) * Update NEWS.md

1 parent 16261c3 commit dc6455fCopy full SHA for dc6455f

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,9 @@`
`1`	`1`	`# plotly (development version)`
`2`	`2`
	`3`	`+## Bug fixes`
	`4`	`+`
	`5`	+* Closed #2337: Creating a new `event_data()` handler no longer causes a spurious reactive update of existing `event_data()`s. (#2339)
	`6`	`+`
`3`	`7`	`# 4.10.4`
`4`	`8`
`5`	`9`	`## Improvements`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ event_data <- function(`
`193`	`193`
`194`	`194`	`} else {`
`195`	`195`
`196`		`- eventHasStorage <- eventID %in% names(session$userData$plotlyInputStore)`
	`196`	`+ eventHasStorage <- eventID %in% shiny::isolate(names(session$userData$plotlyInputStore))`
`197`	`197`
`198`	`198`	`if (!eventHasStorage) {`
`199`	`199`	`# store input value as a reactive value to leverage caching`

Comments

(0)