Commit d1efead

committed

Take changes from #2440

1 parent e217ca8 commit d1efeadCopy full SHA for d1efead

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -784,7 +784,8 @@ gg2list <- function(p, width = NULL, height = NULL,`
`784`	`784`	`# the logic here is similar to what p$coordinates$aspect() does,`
`785`	`785`	`# but the ratio is scaled to the data range by plotly.js`
`786`	`786`	`fixed_coords <- c("CoordSf", "CoordFixed", "CoordMap", "CoordQuickmap")`
`787`		`- if (inherits(p$coordinates, fixed_coords)) {`
	`787`	`+ is_fixed <- isFALSE(p$coordinates$is_free())`
	`788`	`+ if (inherits(p$coordinates, fixed_coords) \|\| is_fixed) {`
`788`	`789`	`axisObj$scaleanchor <- anchor`
`789`	`790`	`ratio <- p$coordinates$ratio %\|\|% 1`
`790`	`791`	`axisObj$scaleratio <- if (xy == "y") ratio else 1 / ratio`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,6 @@ test_that("empty labels work", {`
`51`	`51`	`p <- ggplot(palmerpenguins::penguins,`
`52`	`52`	`aes(bill_length_mm, bill_depth_mm, color = species)) +`
`53`	`53`	`geom_point() +`
`54`		`- labs(x = element_blank(), y = element_blank())`
	`54`	`+ labs(x = NULL, y = NULL)`
`55`	`55`	`b <- expect_doppelganger_built(p, "labs-element-blank")`
`56`	`56`	`})`

Comments

(0)