Commit bfb80b0

committed

Avoid hoveron warning

When converting a ggplot object to webgl, invalid 'hoveron' warnings appear. If the toWebGL() function receives the ggplot object then it is possible for us to remove those warnings. Closes: #2296 Closes: #1582

1 parent 270d20e commit bfb80b0Copy full SHA for bfb80b0

File tree

1 file changed

+13

-0

lines changed

R
- helpers.R

1 file changed

+13

-0

lines changed

`‎R/helpers.R‎`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -162,11 +162,24 @@ hide_legend <- function(p) {`
`162`	`162`	`toWebGL <- function(p) {`
`163`	`163`	`if (ggplot2::is.ggplot(p)) {`
`164`	`164`	`p <- plotly_build(p)`
	`165`	`+ p <- remove_hoveron_from_gl_traces(p)`
`165`	`166`	`}`
`166`	`167`	`p$x$.plotlyWebGl <- TRUE`
`167`	`168`	`p`
`168`	`169`	`}`
`169`	`170`
	`171`	`+# ggplotly automatically assigns hoveron mappings that are incompatible with`
	`172`	`+# webGL based traces, we remove those mappings during toWebGL() conversion`
	`173`	`+# (See #1582)`
	`174`	`+remove_hoveron_from_gl_traces <- function(p) {`
	`175`	`+ traces_without_hoveron <- glTypes()`
	`176`	`+ trace_idx <- vapply(`
	`177`	`+ p$x$data,`
	`178`	`+ function(trace) trace$type %in% traces_without_hoveron,`
	`179`	`+ logical(1)`
	`180`	`+ )`
	`181`	`+ p <- style(p, hoveron = NULL, traces = which(trace_idx))`
	`182`	`+}`
`170`	`183`
`171`	`184`	`#' Create a complete empty plotly graph.`
`172`	`185`	`#'`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit bfb80b0

File tree

1 file changed

1 file changed

`‎R/helpers.R‎`

0 commit comments