This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Commit 75d6563

authored

Merge pull request #84 from plotly/async-kernel

support async kernel in _request_jupyter_config

2 parents 3cd2da4 + 5b54333 commit 75d6563Copy full SHA for 75d6563

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
	`1`	`+import asyncio`
`1`	`2`	`import IPython`
`2`	`3`	`from ipykernel.comm import Comm`
	`4`	`+import nest_asyncio`
`3`	`5`	`import time`
`4`	`6`	`import sys`
`5`	`7`
`@@ -66,7 +68,12 @@ def capture_event(stream, ident, parent):`
`66`	`68`	`if _jupyter_comm_response_received():`
`67`	`69`	`break`
`68`	`70`
`69`		`- kernel.do_one_iteration()`
	`71`	`+ if asyncio.iscoroutinefunction(kernel.do_one_iteration):`
	`72`	`+ nest_asyncio.apply()`
	`73`	`+ loop = asyncio.get_event_loop()`
	`74`	`+ loop.run_until_complete(kernel.do_one_iteration())`
	`75`	`+ else:`
	`76`	`+ kernel.do_one_iteration()`
`70`	`77`
`71`	`78`	`# Stop capturing events, revert the kernel shell handler to the default`
`72`	`79`	`# execute_request behavior`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -220,6 +220,8 @@ def run_server(`
`220`	`220`	`old_server = self._server_threads.get((host, port))`
`221`	`221`	`if old_server:`
`222`	`222`	`old_server.kill()`
	`223`	`+ old_server.join()`
	`224`	`+ del self._server_threads[(host, port)]`
`223`	`225`
`224`	`226`	`# Configure pathname prefix`
`225`	`227`	`requests_pathname_prefix = self.config.get('requests_pathname_prefix', None)`

Lines changed: 1 addition & 0 deletions

Comments

(0)