Commit 0812f20

committed

Added check response signature

1 parent 52e15a1 commit 0812f20Copy full SHA for 0812f20

File tree

+10

-4

lines changed

+10

-4

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,3 +5,4 @@ Tất cả lịch sử tiến trình phát triển thư viện`
`5`	`5`	`## 1.0.1`
`6`	`6`
`7`	`7`	- Implement phương thức `isCancelled` ở lớp `\Omnipay\VTCPay\Message\Response`.
	`8`	+- Throw exception ở concern `\Omnipay\VTCPay\Message\Conerns\ResponseSignatureValidation` khi response không tồn tại chữ ký.

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,14 +23,19 @@ trait ResponseSignatureValidation`
`23`	`23`	`*/`
`24`	`24`	`protected function validateSignature(): void`
`25`	`25`	`{`
`26`		`- $data = $this->getData();`
	`26`	`+ $data = $dataSignature = $this->getData();`
	`27`	`+`
	`28`	`+ if (! isset($data['signature'])) {`
	`29`	`+ throw new InvalidResponseException(sprintf('Response from VTCPay is invalid!'));`
	`30`	`+ }`
	`31`	`+`
`27`	`32`	`$signature = new Signature(`
`28`	`33`	`$this->getRequest()->getSecurityCode()`
`29`	`34`	`);`
`30`		`- $actual = $data['signature'];`
`31`		`- unset($data['signature']);`
`32`	`35`
`33`		`- if (! $signature->validate($data, $actual)) {`
	`36`	`+ unset($dataSignature['signature']);`
	`37`	`+`
	`38`	`+ if (! $signature->validate($dataSignature, $data['signature'])) {`
`34`	`39`	`throw new InvalidResponseException(sprintf('Data signature response from VTCPay is invalid!'));`
`35`	`40`	`}`
`36`	`41`	`}`

Comments

(0)