This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit c99064b

committed

Cleanup and rename hidden prop constructor

1 parent e18ef72 commit c99064bCopy full SHA for c99064b

File tree

1 file changed

-6

lines changed

src
- php_v8_object.cc

1 file changed

-6

lines changed

`‎src/php_v8_object.cc`

Lines changed: 5 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,8 @@ v8::Local<v8::Object> php_v8_value_get_object_local(v8::Isolate *isolate, php_v8`
`40`	`40`
`41`	`41`	`// TODO: cache this private`
`42`	`42`
`43`		`-inline v8::Local<v8::Private> GetHiddenPropertyName(v8::Isolate* isolate) {`
`44`		`-// v8::MaybeLocal<v8::String> local_key = v8::String::NewFromUtf8(isolate, "php_v8::self", v8::NewStringType::kInternalized);`
`45`		`- v8::MaybeLocal<v8::String> local_key = v8::String::NewFromUtf8(isolate, "test", v8::NewStringType::kInternalized);`
	`43`	`+inline v8::Local<v8::Private> php_v8_get_hidden_property_name(v8::Isolate *isolate) {`
	`44`	`+ v8::MaybeLocal<v8::String> local_key = v8::String::NewFromUtf8(isolate, "php-v8::self", v8::NewStringType::kInternalized);`
`46`	`45`
`47`	`46`	`assert(!local_key.IsEmpty());`
`48`	`47`
`@@ -65,7 +64,7 @@ bool php_v8_object_delete_self_ptr(v8::Isolate *isolate, v8::Local<v8::Object> l`
`65`	`64`	`PHP_V8_ISOLATE_ENTER(isolate);`
`66`	`65`	`PHP_V8_CONTEXT_ENTER(local_object->CreationContext());`
`67`	`66`
`68`		`- v8::Local<v8::Private> key = GetHiddenPropertyName(isolate);`
	`67`	`+ v8::Local<v8::Private> key = php_v8_get_hidden_property_name(isolate);`
`69`	`68`
`70`	`69`	`assert(!key.IsEmpty());`
`71`	`70`
`@@ -93,7 +92,7 @@ bool php_v8_object_store_self_ptr(v8::Isolate *isolate, v8::Local<v8::Object> lo`
`93`	`92`	`// PHP_V8_ISOLATE_ENTER(isolate);`
`94`	`93`	`// PHP_V8_CONTEXT_ENTER(local_object->CreationContext());`
`95`	`94`
`96`		`- v8::Local<v8::Private> key = GetHiddenPropertyName(isolate);`
	`95`	`+ v8::Local<v8::Private> key = php_v8_get_hidden_property_name(isolate);`
`97`	`96`	`assert(!key.IsEmpty());`
`98`	`97`
`99`	`98`	`v8::Local<v8::External> this_embedded = v8::External::New(isolate, php_v8_value);`
`@@ -123,7 +122,7 @@ php_v8_value_t * php_v8_object_get_self_ptr(v8::Isolate *isolate, v8::Local<v8::`
`123`	`122`	`// PHP_V8_ISOLATE_ENTER(isolate);`
`124`	`123`	`// PHP_V8_CONTEXT_ENTER(local_object->CreationContext());`
`125`	`124`
`126`		`- v8::Local<v8::Private> key = GetHiddenPropertyName(isolate);`
	`125`	`+ v8::Local<v8::Private> key = php_v8_get_hidden_property_name(isolate);`
`127`	`126`	`assert(!key.IsEmpty());`
`128`	`127`
`129`	`128`	`v8::MaybeLocal<v8::Value> maybe_local_value = local_object->GetPrivate(local_object->CreationContext(), key);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c99064b

File tree

1 file changed

1 file changed

`‎src/php_v8_object.cc`

0 commit comments