This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 6569d98

authored

Merge pull request #17 from pinepain/fix-tests

Fix tests

2 parents 2646cca + 6e24213 commit 6569d98Copy full SHA for 6569d98

File tree

-7

lines changed

-7

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,8 @@ before_install:`
`24`	`24`	`- sudo add-apt-repository ppa:pinepain/libv8-${V8} -y`
`25`	`25`	`- sudo apt-get update -q`
`26`	`26`	`- sudo apt-get install -y libv8-${V8}-dev`
	`27`	`+ - php -i`
	`28`	`+ - php-config \|\| true`
`27`	`29`
`28`	`30`	`before_script:`
`29`	`31`	`- echo 'variables_order = "EGPCS"' >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ $helper->space();`
`54`	`54`
`55`	`55`
`56`	`56`	`$helper->header('Test negative value in constructor');`
`57`		`-$value = new V8\Int32Value($isolate, -123.456);`
	`57`	`+$value = new V8\Int32Value($isolate, -123);`
`58`	`58`	`$helper->method_export($value, 'Value');`
`59`	`59`	`$helper->method_export($value, 'BooleanValue', [$context]);`
`60`	`60`	`$helper->method_export($value, 'NumberValue', [$context]);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ $helper->space();`
`54`	`54`
`55`	`55`
`56`	`56`	`$helper->header('Test negative value in constructor');`
`57`		`-$value = new V8\IntegerValue($isolate, -123.456);`
	`57`	`+$value = new V8\IntegerValue($isolate, -123);`
`58`	`58`	`$helper->method_export($value, 'Value');`
`59`	`59`	`$helper->method_export($value, 'BooleanValue', [$context]);`
`60`	`60`	`$helper->method_export($value, 'NumberValue', [$context]);`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@ $v8_helper = new PhpV8Helpers($helper);`
`13`	`13`
`14`	`14`	`// Tests:`
`15`	`15`
`16`		`-`
`17`	`16`	`$isolate = new V8\Isolate();`
`18`	`17`
`19`	`18`	`$default = new V8\StringValue($isolate);`
`@@ -87,7 +86,6 @@ foreach (['Hello, world!', 'Привет, мир!', 'こんにちは世界'] as`
`87`	`86`	`$helper->method_export($value, 'ContainsOnlyOneByte');`
`88`	`87`
`89`	`88`	`$helper->function_export('strlen', [$value->Value()]);`
`90`		`- $helper->function_export('mb_strlen', [$value->Value()]);`
`91`	`89`	`$helper->space();`
`92`	`90`	`}`
`93`	`91`
`@@ -207,7 +205,6 @@ V8\StringValue->Utf8Length(): int(13)`
`207`	`205`	`V8\StringValue->IsOneByte(): bool(true)`
`208`	`206`	`V8\StringValue->ContainsOnlyOneByte(): bool(true)`
`209`	`207`	`strlen(): 13`
`210`		`-mb_strlen(): 13`
`211`	`208`
`212`	`209`
`213`	`210`	`V8\StringValue->Value(): string(21) "Привет, мир!"`
`@@ -216,7 +213,6 @@ V8\StringValue->Utf8Length(): int(21)`
`216`	`213`	`V8\StringValue->IsOneByte(): bool(false)`
`217`	`214`	`V8\StringValue->ContainsOnlyOneByte(): bool(false)`
`218`	`215`	`strlen(): 21`
`219`		`-mb_strlen(): 12`
`220`	`216`
`221`	`217`
`222`	`218`	`V8\StringValue->Value(): string(21) "こんにちは世界"`
`@@ -225,4 +221,3 @@ V8\StringValue->Utf8Length(): int(21)`
`225`	`221`	`V8\StringValue->IsOneByte(): bool(false)`
`226`	`222`	`V8\StringValue->ContainsOnlyOneByte(): bool(false)`
`227`	`223`	`strlen(): 21`
`228`		`-mb_strlen(): 7`

Comments

(0)