Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 57ed46a

Browse files
committed
Phase out vagrant and ppa
1 parent 04d550a commit 57ed46a

File tree

8 files changed

+11
-257
lines changed

8 files changed

+11
-257
lines changed

‎Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM pinepain/libv8:latest
1+
FROM phpv8/libv8:latest
22

33
ARG PHP=7.2
44

‎Vagrantfile

Lines changed: 0 additions & 26 deletions
This file was deleted.

‎docs/development/release-libv8.rst

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,20 @@
22
Release libv8
33
*************
44

5-
We will start with building Ubuntu PPA first as it used in further CI process to validate that ``php-v8`` is not broken.
5+
Currently Docker is the recommended way to distribute and use both php-v8 and libv8 itself. We also support building
6+
``libv8`` in macOS with Homebrew via `phpv8/tap`_ tap.
67

78
To track v8 changes you can use these links:
89

910
* https://github.com/v8/v8/commits/master/include/v8.h - to keep track on v8 upstream changes
1011
* https://omahaproxy.appspot.com/ - to keep track v8 channel(version) heads and what version is used in chrome
1112

12-
Building libv8
13-
==============
13+
Building docker image
14+
=====================
1415

15-
#. **Skip this step if you are updating v8 patch release version.** To bump minor v8 version (e.g. from 6.3 to 6.4),
16-
create new ``libv8-X.Y`` PPA for new version. As V8 could be build for ``i386`` but only from ``amd64``, which is not how PPA
17-
works, it's also make sense to keep new PPA ``amd64``-only. Also we don't use ``i386`` so we don't want to worry about it.
18-
#. Update libv8 Makefile (``packaging/libv8/Makefile``) with new libv8 version by setting proper values in
19-
``GIT_VERSION=X.Y.Z`` and ``NAME=libv8-X.Y`` variables.
20-
#. Commit changes with ``build libv8`` commit message and wait until libv8 PPA build done.
21-
22-
After libv8 PPA build done
23-
==========================
24-
25-
#. Copy fresh ``libv8-X.Y`` build packages from ``experimental`` (default target for all libv8 builds we trigger)
26-
to it ``libv8-X.Y`` PPA. Do not rebuild, just copy binaries.
27-
#. **Wait for packages copied and published!**
28-
#. Build `phpv8/libv8`_ docker image, tag it with the
29-
relevant v8 full version and push to Docker Hub.
16+
#. Build `phpv8/libv8`_ docker image, tag it with the relevant v8 full version and push to Docker Hub.
17+
Hint: use ``Makefile``.
3018
#. You may want to set proper ``V8`` version in ``php-v8`` by updating it in ``.travis.yml``.
31-
#. Make sure you have proper ``V8`` version set in ``packaging/Dockerfile`` under ``V8`` constant.
3219

3320
After docker images rebuilt/published
3421
=====================================
@@ -40,11 +27,8 @@ After docker images rebuilt/published
4027
#. Also, update references to v8 version in `php-v8`_/scripts/provision/provision.sh,
4128
it's normally could be done by replacing old version with new, e.g. ``6.3`` => ``6.4``.
4229
#. On every version bump update `php-v8`_ ``README.md`` file with proper min v8 version required/tested.
43-
#. If you use vagrant, re-provision your local development environment at this step to fetch/add new ``libv8`` version.
44-
It's generally a good idea to remove old ``libv8`` versions as well and remove their PPA from apt sources list at this point.
4530
#. **Make sure** you tested `php-v8`_ locally first before pushing to remote,
46-
upgrading v8 could be tricky as it may break BC even in patch releases (that's why we started to have separate
47-
PPAs for minor version to somehow couple with this issue in minor releases).
31+
upgrading v8 could be tricky as it may break BC even in patch releases.
4832
#. Note, that doing all this in a separate branch and merging that later into master is a nice and safe idea
4933
(note, you may skip PR overhead and do fast-forward merge locally to master).
5034
#. Commit message should state that it is v8 version bump, e.g. ``Require libv8 >= X.Y.Z``
@@ -61,3 +45,4 @@ Building packages for macOS Homebrew
6145

6246
.. _php-v8: https://github.com/phpv8/php-v8
6347
.. _phpv8/libv8: https://github.com/phpv8/dockerfiles/tree/master/libv8
48+
.. _phpv8/tap: https://github.com/phpv8/homebrew-tap

‎docs/development/release-php-v8.rst

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -29,28 +29,7 @@ PECL release
2929
#. Run ``pecl package`` in your build machine (it's normally vagrant box used for ``php-v8`` development). It should create
3030
``v8-X.Y.Z.tgz`` file.
3131
#. Log in to PECL and upload file from previous step at https://pecl.php.net/release-upload.php. Verify that release info
32-
is accurate and confirm release.
33-
34-
Ubuntu PPA release
35-
==================
36-
37-
#. Copy targeted ``libv8-X.Y`` build to ``php`` ppa without rebuild, just copy.
38-
#. Make sure you have proper PHP and ``php-v8`` PPA dependencies set in https://launchpad.net/~pinepain/+archive/ubuntu/php-v8/+edit-dependencies
39-
#. Make sure you have proper ``php-v8`` version set in ``packaging/Dockerfile`` under ``V8`` constant.
40-
#. In ``packaging/php-v8/Makefile`` set proper ``VERSION=X.Y.Z``
41-
#. Make sure you have valid ``libv8`` dependency in ``packaging/php-v8/debian/control`` file.
42-
#. Commit changes with ``build php-v8`` commit message and wait until libv8 PPA build done.
43-
#. Copy ``php-v8`` packages to ``pinepain/php`` PPA, do not rebuild, just copy.
44-
#. After they get copied, feels free to remove **old** ``libv8`` packages from ``pinepain/php`` ppa.
45-
46-
macOS Homebrew release
47-
======================
48-
49-
#. Update ``php7*-v8`` formula **one by one** to have proper ``depends_on 'v8@X.Y'``
50-
and ``v8_prefix=Formula['v8@X.Y'].opt_prefix`` values.
51-
#. If you want to rebuild existent version, add/increment ``revision`` in formula body.
52-
#. If version has already been published to bintray and you absolutely sure it needs to be re-built without revision.
53-
bump, you will need to delete such version from bintray first.
32+
is accurate and confirm release.
5433

5534
Docker image release
5635
====================
@@ -65,8 +44,7 @@ Docker image release
6544
After all
6645
=========
6746

68-
#. Update `js-sandbox`_ ``.travis.yml`` and ``.scrutinizer.yml``
69-
to refer to new ``php-v8`` version and to relevant ``libv8`` PPA and packages.
47+
#. Update `js-sandbox`_ dependencies, if required, to use latest ``php-v8`` and other dependencies, if any.
7048
#. Update ``PHP_V8_VERSION`` to the next version and set ``PHP_V8_REVISION`` to ``dev`` in ``php_v8.h``.
7149
#. Commit changes with ``Back to dev [skip ci]`` message and push them to master.
7250

‎docs/getting-started/donate.rst

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎docs/index.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
Welcome to php-v8's documentation!
22
==================================
33

4-
.. include:: getting-started/donate.rst
5-
64
About
75
=====
86

‎scripts/provision/.bashrc

Lines changed: 0 additions & 133 deletions
This file was deleted.

‎scripts/provision/provision.sh

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /