Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 17ba2ff

Browse files
committed
Drop PHP 7.1 support
1 parent 9569c19 commit 17ba2ff

File tree

13 files changed

+24
-35
lines changed

13 files changed

+24
-35
lines changed

‎.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ env:
1010
matrix:
1111
- PHP=7.2
1212
- PHP=7.2 TEST_PHP_ARGS=-m
13-
- PHP=7.1
14-
- PHP=7.1 TEST_PHP_ARGS=-m
1513

1614
before_install:
1715
# docker on travis doesn't allow anything before FROM, let's fix that

‎README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ PHP extension for V8 JavaScript engine
66
[![Docs](https://readthedocs.org/projects/php-v8/badge/)](https://php-v8.readthedocs.io)
77

88

9-
**This extension requires PHP >= 7.1**. Last version that supports PHP 7.0 is v0.1.9.
9+
**This extension requires PHP >= 7.2**. Last version that supports PHP 7.1 is v0.2.2 and for PHP 7.0 is v0.1.9.
1010

1111
**This extension is still under heavy development and its public API may change without any warning. Use at your own risk.**
1212

@@ -108,7 +108,7 @@ on top of php-v8 extension and makes embedding JavaScript in PHP easier.
108108
You will need a recent v8 Google JavaScript engine version installed. At this time v8 >= 6.6.313 required.
109109

110110
#### PHP
111-
This extension is PHP7-only. It works and tested with both PHP 7.0 and PHP 7.1.
111+
**This extension requires PHP >= 7.2**. Last version that supports PHP 7.1 is v0.2.2 and for PHP 7.0 is v0.1.9.
112112

113113
#### OS
114114
This extension works and tested on x64 Linux and macOS. As of written it is Ubuntu 16.04 LTS Xenial Xerus, amd64
@@ -122,7 +122,7 @@ and macOS 10.12.5. Windows is not supported at this time.
122122
$ sudo add-apt-repository -y ppa:ondrej/php
123123
$ sudo add-apt-repository -y ppa:pinepain/php
124124
$ sudo apt-get update -y
125-
$ sudo apt-get install -y php7.1 php-v8
125+
$ sudo apt-get install -y php7.2 php-v8
126126
$ php --ri v8
127127
```
128128

@@ -139,7 +139,7 @@ extensions with dependencies, you may find
139139
$ brew tap homebrew/dupes
140140
$ brew tap homebrew/php
141141
$ brew tap pinepain/devtools
142-
$ brew install php71 php71-v8
142+
$ brew install php72 php72-v8
143143
$ php --ri v8
144144
```
145145

‎config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ if test "$PHP_V8" != "no"; then
77
PHP_REF_FOUND_VERSION=`${PHP_CONFIG} --version`
88
PHP_REF_FOUND_VERNUM=`${PHP_CONFIG} --vernum`
99

10-
if test "$PHP_REF_FOUND_VERNUM" -lt "70100"; then
11-
AC_MSG_ERROR([not supported. PHP version >= 7.1 required (found $PHP_REF_FOUND_VERSION)])
10+
if test "$PHP_REF_FOUND_VERNUM" -lt "70200"; then
11+
AC_MSG_ERROR([not supported. PHP version >= 7.2 required (found $PHP_REF_FOUND_VERSION)])
1212
else
1313
AC_MSG_RESULT([supported ($PHP_REF_FOUND_VERSION)])
1414
fi

‎docs/getting-started/index.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ You will need a recent v8 Google JavaScript engine version installed. At this ti
7070
PHP
7171
"""
7272

73-
This extension is PHP7-only. It works and tested with both PHP 7.0 and PHP 7.1.
73+
**This extension requires PHP >= 7.2**. Last version that supports PHP 7.1 is v0.2.2 and for PHP 7.0 is v0.1.9.
74+
7475

7576
OS
7677
"""

‎package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@
423423
<dependencies>
424424
<required>
425425
<php>
426-
<min>7.1</min>
426+
<min>7.2</min>
427427
</php>
428428
<pearinstaller>
429429
<min>1.4.0</min>

‎perf/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
}
1414
],
1515
"require": {
16-
"php": "~7.1",
16+
"php": "~7.2",
1717
"phpbench/phpbench": "^0.13.0"
1818
},
1919
"autoload": {

‎php_v8.h

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ extern zend_module_entry php_v8_module_entry;
5050
#define PHP_V8_LIBV8_VERSION "undefined"
5151
#endif
5252

53-
#if PHP_VERSION_ID < 70100
53+
#if PHP_VERSION_ID < 70200
5454
// should never get her, but just in case
55-
#error PHP >= 7.1 required
55+
#error PHP >= 7.2 required
5656
#endif
5757

5858

@@ -61,20 +61,11 @@ ZEND_BEGIN_MODULE_GLOBALS(v8)
6161
v8::Platform *platform;
6262
ZEND_END_MODULE_GLOBALS(v8)
6363

64-
// Add zend_type support (new since PHP 7.2)
65-
#ifdef ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX
66-
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(name, return_reference, required_num_args, classname, allow_null) \
67-
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(name, return_reference, required_num_args, classname, allow_null)
64+
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(name, return_reference, required_num_args, classname, allow_null) \
65+
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(name, return_reference, required_num_args, classname, allow_null)
6866

69-
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, type, allow_null) \
70-
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, type, allow_null)
71-
#else
72-
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(name, return_reference, required_num_args, classname, allow_null) \
73-
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, IS_OBJECT, #classname, allow_null)
74-
75-
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, type, allow_null) \
76-
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, type, NULL, allow_null)
77-
#endif
67+
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, type, allow_null) \
68+
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(name, return_reference, required_num_args, type, allow_null)
7869

7970
#define PHP_V8_ZEND_BEGIN_ARG_WITH_CONSTRUCTOR_INFO_EX(name, required_num_args) ZEND_BEGIN_ARG_INFO_EX(name, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, required_num_args)
8071
#define PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_VOID_INFO_EX(name, required_num_args) ZEND_BEGIN_ARG_INFO_EX(name, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, required_num_args)

‎src/php_v8_null.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ PHP_V8_ZEND_BEGIN_ARG_WITH_CONSTRUCTOR_INFO_EX(arginfo___construct, 1)
4747
ZEND_ARG_OBJ_INFO(0, isolate, V8\\Isolate, 0)
4848
ZEND_END_ARG_INFO()
4949

50-
// no strict typing as it returns NULL and null typehint doesn't work on PHP 7.1
51-
ZEND_BEGIN_ARG_INFO_EX(arginfo_value, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 0)
50+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_value, ZEND_RETURN_VALUE, 0, IS_NULL, 0)
5251
ZEND_END_ARG_INFO()
5352

53+
5454
static const zend_function_entry php_v8_null_methods[] = {
5555
PHP_V8_ME(NullValue, __construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
5656
PHP_V8_ME(NullValue, value, ZEND_ACC_PUBLIC)

‎src/php_v8_undefined.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ PHP_V8_ZEND_BEGIN_ARG_WITH_CONSTRUCTOR_INFO_EX(arginfo___construct, 1)
5050
ZEND_ARG_OBJ_INFO(0, isolate, V8\\Isolate, 0)
5151
ZEND_END_ARG_INFO()
5252

53-
// no strict typing as it returns NULL and null typehint doesn't work on PHP 7.1
54-
ZEND_BEGIN_ARG_INFO_EX(arginfo_value, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 0)
53+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_value, ZEND_RETURN_VALUE, 0, IS_NULL, 0)
5554
ZEND_END_ARG_INFO()
5655

5756

‎stubs/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
}
1414
],
1515
"require": {
16-
"php": "~7.1"
16+
"php": "~7.2"
1717
}
1818
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /