This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit e49f0ed

committed

Set null type implicitly for nullable paramater definition

1 parent bf92724 commit e49f0edCopy full SHA for e49f0ed

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,11 @@ protected function buildOptionalParameterSpec(array $matches, ?string $default):`
`143`	`143`	`}`
`144`	`144`	`}`
`145`	`145`
	`146`	`+ if ($this->hasNullable($matches)) {`
	`147`	`+ // nullable means that null is a valid value and thus we should explicitly enable null extractor here`
	`148`	`+ $matches['type'] = 'null\|' . $matches['type'];`
	`149`	`+ }`
	`150`	`+`
`146`	`151`	`return new OptionalParameterSpec($matches['name'], $this->extractor->build($matches['type']), $default);`
`147`	`152`	`}`
`148`	`153`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ public function testBuildingNullableParameterWithDefaultValueShouldThrowExceptio`
`199`	`199`
`200`	`200`	`public function testBuildingNullableParameter()`
`201`	`201`	`{`
`202`		`- $this->extractorDefinitionShouldBuildOn('type');`
	`202`	`+ $this->extractorDefinitionShouldBuildOn('null\|type');`
`203`	`203`
`204`	`204`	`$spec = $this->builder->build('param? : type');`
`205`	`205`
`@@ -255,7 +255,7 @@ public function testBuildingParameterWithBoolFalseTypeGuessing()`
`255`	`255`	`public function testBuildingParameterWithNullableTypeGuessing()`
`256`	`256`	`{`
`257`	`257`	`$this->argumentDefinitionShouldBuildOn('null');`
`258`		`- $this->extractorDefinitionShouldBuildOn('any');`
	`258`	`+ $this->extractorDefinitionShouldBuildOn('null\|any');`
`259`	`259`
`260`	`260`	`$spec = $this->builder->build('param?');`
`261`	`261`

Comments

(0)