This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit a8cd558

committed

Pass runtime function to allow on the fly callback swap

1 parent 1157ac8 commit a8cd558Copy full SHA for a8cd558

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,8 @@`
`16`	`16`	`namespace Pinepain\JsSandbox\Wrappers\FunctionComponents;`
`17`	`17`
`18`	`18`
`19`		`-use Pinepain\JsSandbox\Specs\FunctionSpecInterface;`
`20`	`19`	`use Pinepain\JsSandbox\Wrappers\FunctionComponents\Runtime\ColdExecutionContextInterface;`
	`20`	`+use Pinepain\JsSandbox\Wrappers\Runtime\RuntimeFunctionInterface;`
`21`	`21`	`use Throwable;`
`22`	`22`	`use V8\FunctionCallbackInfo;`
`23`	`23`
`@@ -59,9 +59,12 @@ public function __construct(`
`59`	`59`	`$this->return_setter = $return_setter;`
`60`	`60`	`}`
`61`	`61`
`62`		`- public function wrap(callable$callback, FunctionSpecInterface$spec, ColdExecutionContextInterface $cold_execution_context)`
	`62`	`+ public function wrap(RuntimeFunctionInterface$function, ColdExecutionContextInterface $cold_execution_context)`
`63`	`63`	`{`
`64`		`- return function (FunctionCallbackInfo $args) use ($callback, $spec, $cold_execution_context) {`
	`64`	`+ return function (FunctionCallbackInfo $args) use ($function, $cold_execution_context) {`
	`65`	`+ $spec = $function->getSpec();`
	`66`	`+ $callback = $function->getCallback();`
	`67`	`+`
`65`	`68`	`$arguments = $this->arguments_extractor->extract($args, $spec);`
`66`	`69`
`67`	`70`	`if ($spec->getDecorators()) {`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,10 @@`
`18`	`18`
`19`	`19`	`use Pinepain\JsSandbox\Specs\FunctionSpecInterface;`
`20`	`20`	`use Pinepain\JsSandbox\Wrappers\FunctionComponents\Runtime\ColdExecutionContextInterface;`
	`21`	`+use Pinepain\JsSandbox\Wrappers\Runtime\RuntimeFunctionInterface;`
`21`	`22`
`22`	`23`
`23`	`24`	`interface FunctionCallHandlerInterface`
`24`	`25`	`{`
`25`		`- public function wrap(callable$callback, FunctionSpecInterface$spec, ColdExecutionContextInterface $cold_execution_context);`
	`26`	`+ public function wrap(RuntimeFunctionInterface$function, ColdExecutionContextInterface $cold_execution_context);`
`26`	`27`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public function wrap(Isolate $isolate, Context $context, $value): FunctionObject`
`77`	`77`
`78`	`78`	`$cold_execution_context = new ColdExecutionContext($this->wrapper, $value);`
`79`	`79`
`80`		`- $callback = $this->handler->wrap($value->getCallback(), $value->getSpec(), $cold_execution_context);`
	`80`	`+ $callback = $this->handler->wrap($value, $cold_execution_context);`
`81`	`81`	`$callback = $this->guard->guard($callback);`
`82`	`82`
`83`	`83`	`$f = new FunctionObject($context, $callback);`

Comments

(0)