This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 8101fac

committed

Cleanup default parameter string extracting

1 parent e1f0fa0 commit 8101facCopy full SHA for 8101fac

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,7 @@ protected function buildDefaultValue(string $definition)`
`141`	`141`	`// after this point all expected definition values MUST be at least 2 chars length`
`142`	`142`
`143`	`143`	`if (strlen($definition) < 2) {`
	`144`	`+ // UNEXPECTED`
`144`	`145`	`// Less likely we will ever get here because it should fail at a parsing step, but just in case`
`145`	`146`	`throw new ParameterSpecBuilderException("Unknown default value format '{$definition}'");`
`146`	`147`	`}`
`@@ -149,11 +150,10 @@ protected function buildDefaultValue(string $definition)`
`149`	`150`	`return [];`
`150`	`151`	`}`
`151`	`152`
`152`		`- if ('"' == $definition[0] && '"' == $definition[-1]) {`
`153`		`- return trim($definition, '"');`
`154`		`- }`
`155`		`- if ("'" == $definition[0] && "'" == $definition[-1]) {`
`156`		`- return trim($definition, "'");`
	`153`	`+ foreach (['"', "'"] as $quote) {`
	`154`	`+ if ($quote == $definition[0] && $quote == $definition[-1]) {`
	`155`	`+ return trim($definition, $quote);`
	`156`	`+ }`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`// Less likely we will ever get here because it should fail at a parsing step, but just in case`

Comments

(0)