This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 033b460

committed

Move variadic dots from parame type to param name

This should make param typing more intuitive and unify it with how it is done in PHP, JavaScript, TypeScript and others

1 parent 85d4ebc commit 033b460Copy full SHA for 033b460

File tree

-6

lines changed

-6

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,14 @@ class ParameterSpecBuilder implements ParameterSpecBuilderInterface`
`30`	`30`	`{`
`31`	`31`	`protected $regexp = '/`
`32`	`32`	`^`
`33`		`- (?:`
`34`		`- (?<rest>\.{3})`
`35`		`- \s*`
`36`		`- )?`
`37`	`33`	`(?:`
`38`	`34`	`(?<type>(\w+\b(?:$.$)?)(?:\s\\|\s(?-1)))`
`39`	`35`	`\s*`
`40`	`36`	`)`
	`37`	`+ (?:`
	`38`	`+ (?<rest>\.{3})`
	`39`	`+ \s*`
	`40`	`+ )?`
`41`	`41`	`(?<name>[_a-z]\w*)`
`42`	`42`	`(?:`
`43`	`43`	`\s* = \s*`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public function testBuildingVariadicParameter()`
`124`	`124`	`{`
`125`	`125`	`$this->extractorDefinitionShouldBuildOn('type');`
`126`	`126`
`127`		`- $spec = $this->builder->build('...type param');`
	`127`	`+ $spec = $this->builder->build('type ...param');`
`128`	`128`
`129`	`129`	`$this->assertInstanceOf(VariadicParameterSpec::class, $spec);`
`130`	`130`
`@@ -138,7 +138,7 @@ public function testBuildingVariadicParameter()`
`138`	`138`	`*/`
`139`	`139`	`public function testBuildingVariadicParameterWithDefaultValueShouldThrowException()`
`140`	`140`	`{`
`141`		`- $this->builder->build('...type param = []');`
	`141`	`+ $this->builder->build('type ...param = []');`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`/**`

Comments

(0)