Commit e7767d9

eliashaeusslerondrejmirtes

authored and

committed

Skip check for negatable input options on symfony/console < 5.3

Related: #300

1 parent a14d467 commit e7767d9Copy full SHA for e7767d9

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,10 @@`
`1`	`1`	`parameters:`
`2`	`2`	`ignoreErrors:`
	`3`	`+ -`
	`4`	`+ message: "#^Call to function method_exists\$\$ with Symfony\\\\Component\\\\Console\\\\Input\\\\InputOption and 'isNegatable' will always evaluate to true\\.$#"`
	`5`	`+ count: 1`
	`6`	`+ path: src/Type/Symfony/GetOptionTypeHelper.php`
	`7`	`+`
`3`	`8`	`-`
`4`	`9`	`message: "#^Accessing PHPStan\\\\Rules\\\\Methods\\\\CallMethodsRule\\:\\:class is not covered by backward compatibility promise\\. The class might change in a minor PHPStan version\\.$#"`
`5`	`10`	`count: 1`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,14 +12,15 @@`
`12`	`12`	`use PHPStan\Type\TypeCombinator;`
`13`	`13`	`use PHPStan\Type\UnionType;`
`14`	`14`	`use Symfony\Component\Console\Input\InputOption;`
	`15`	`+use function method_exists;`
`15`	`16`
`16`	`17`	`class GetOptionTypeHelper`
`17`	`18`	`{`
`18`	`19`
`19`	`20`	`public function getOptionType(Scope $scope, InputOption $option): Type`
`20`	`21`	`{`
`21`	`22`	`if (!$option->acceptValue()) {`
`22`		`- if ($option->isNegatable()) {`
	`23`	`+ if (method_exists($option, 'isNegatable') && $option->isNegatable()) {`
`23`	`24`	`return new UnionType([new BooleanType(), new NullType()]);`
`24`	`25`	`}`
`25`	`26`

Comments

(0)