Commit d0e1b1f

committed

Fix false positive about private service in service subscriber

1 parent a5aed92 commit d0e1b1fCopy full SHA for d0e1b1f

File tree

2 files changed

+22

-1

lines changed

src/Rules/Symfony
- ContainerInterfacePrivateServiceRule.php
tests/Rules/Symfony
- ExampleServiceSubscriber.php

2 files changed

+22

-1

lines changed

`‎src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php‎`

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,9 @@`
`8`	`8`	`use PHPStan\Rules\Rule;`
`9`	`9`	`use PHPStan\ShouldNotHappenException;`
`10`	`10`	`use PHPStan\Symfony\ServiceMap;`
	`11`	`+use PHPStan\TrinaryLogic;`
`11`	`12`	`use PHPStan\Type\ObjectType;`
	`13`	`+use PHPStan\Type\Type;`
`12`	`14`	`use function sprintf;`
`13`	`15`
`14`	`16`	`/**`
`@@ -53,7 +55,7 @@ public function processNode(Node $node, Scope $scope): array`
`53`	`55`
`54`	`56`	`$isTestContainerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType);`
`55`	`57`	`$isOldServiceSubscriber = (new ObjectType('Symfony\Component\DependencyInjection\ServiceSubscriberInterface'))->isSuperTypeOf($argType);`
`56`		`- $isServiceSubscriber = (newObjectType('Symfony\Contracts\Service\ServiceSubscriberInterface'))->isSuperTypeOf($argType);`
	`58`	`+ $isServiceSubscriber = $this->isServiceSubscriber($argType, $scope);`
`57`	`59`	`$isServiceLocator = (new ObjectType('Symfony\Component\DependencyInjection\ServiceLocator'))->isSuperTypeOf($argType);`
`58`	`60`	`if ($isTestContainerType->yes() \|\| $isOldServiceSubscriber->yes() \|\| $isServiceSubscriber->yes() \|\| $isServiceLocator->yes()) {`
`59`	`61`	`return [];`
`@@ -83,4 +85,12 @@ public function processNode(Node $node, Scope $scope): array`
`83`	`85`	`return [];`
`84`	`86`	`}`
`85`	`87`
	`88`	`+ private function isServiceSubscriber(Type $containerType, Scope $scope): TrinaryLogic`
	`89`	`+ {`
	`90`	`+ $serviceSubscriberInterfaceType = new ObjectType('Symfony\Contracts\Service\ServiceSubscriberInterface');`
	`91`	`+ $containedClassType = new ObjectType($scope->getClassReflection()->getName());`
	`92`	`+ return $serviceSubscriberInterfaceType->isSuperTypeOf($containerType)`
	`93`	`+ ->or($serviceSubscriberInterfaceType->isSuperTypeOf($containedClassType));`
	`94`	`+ }`
	`95`	`+`
`86`	`96`	`}`

`‎tests/Rules/Symfony/ExampleServiceSubscriber.php‎`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,14 +2,25 @@`
`2`	`2`
`3`	`3`	`namespace PHPStan\Rules\Symfony;`
`4`	`4`
	`5`	`+use Psr\Container\ContainerInterface;`
`5`	`6`	`use Symfony\Contracts\Service\ServiceSubscriberInterface;`
`6`	`7`
`7`	`8`	`final class ExampleServiceSubscriber implements ServiceSubscriberInterface`
`8`	`9`	`{`
	`10`	`+ /**`
	`11`	`+ * @var ContainerInterface`
	`12`	`+ */`
	`13`	`+ private $locator;`
	`14`	`+`
	`15`	`+ public function __construct(ContainerInterface $locator)`
	`16`	`+ {`
	`17`	`+ $this->locator = $locator;`
	`18`	`+ }`
`9`	`19`
`10`	`20`	`public function privateService(): void`
`11`	`21`	`{`
`12`	`22`	`$this->get('private');`
	`23`	`+ $this->locator->get('private');`
`13`	`24`	`}`
`14`	`25`
`15`	`26`	`public function containerParameter(): void`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit d0e1b1f

File tree

2 files changed

2 files changed

`‎src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php‎`

`‎tests/Rules/Symfony/ExampleServiceSubscriber.php‎`

0 commit comments