Commit c4da70e

committed

Fix invalid option default argument

1 parent 1f1527e commit c4da70eCopy full SHA for c4da70e

File tree

+10

-5

lines changed

+10

-5

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`use PHPStan\Type\Constant\ConstantBooleanType;`
`12`	`12`	`use PHPStan\Type\Constant\ConstantIntegerType;`
`13`	`13`	`use PHPStan\Type\IntegerType;`
	`14`	`+use PHPStan\Type\MixedType;`
`14`	`15`	`use PHPStan\Type\NullType;`
`15`	`16`	`use PHPStan\Type\ObjectType;`
`16`	`17`	`use PHPStan\Type\StringType;`
`@@ -76,8 +77,8 @@ public function processNode(Node $node, Scope $scope): array`
`76`	`77`	`}`
`77`	`78`
`78`	`79`	`// is array`
`79`		`- if (($mode & 8) === 8 && !(new UnionType([new ArrayType(new IntegerType(), new StringType()), new NullType()]))->isSuperTypeOf($defaultType)->yes()) {`
`80`		`- return [sprintf('Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<int, string>\|null, %s given.', $defaultType->describe(VerbosityLevel::typeOnly()))];`
	`80`	`+ if (($mode & 8) === 8 && !(new UnionType([new ArrayType(new MixedType(), new StringType()), new NullType()]))->isSuperTypeOf($defaultType)->yes()) {`
	`81`	`+ return [sprintf('Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<string>\|null, %s given.', $defaultType->describe(VerbosityLevel::typeOnly()))];`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`return [];`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,10 @@ protected function configure(): void`
`29`	`29`	`$this->addOption('b', null, InputOption::VALUE_IS_ARRAY \| InputOption::VALUE_OPTIONAL, '', [1]);`
`30`	`30`	`$this->addOption('c', null, InputOption::VALUE_OPTIONAL, '', 1);`
`31`	`31`	`$this->addOption('d', null, InputOption::VALUE_OPTIONAL, '', false);`
	`32`	`+`
	`33`	`+ /** @var string[] $defaults */`
	`34`	`+ $defaults = [];`
	`35`	`+ $this->addOption('e', null, InputOption::VALUE_IS_ARRAY \| InputOption::VALUE_OPTIONAL, '', $defaults);`
`32`	`36`	`}`
`33`	`37`
`34`	`38`	`protected function execute(InputInterface $input, OutputInterface $output): int`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function testGetArgument(): void`
`21`	`21`	`],`
`22`	`22`	`[`
`23`	`23`	`[`
`24`		`- 'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<int, string>\|null, array<int, int> given.',`
	`24`	`+ 'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<string>\|null, array<int, int> given.',`
`25`	`25`	`29,`
`26`	`26`	`],`
`27`	`27`	`]`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function testGetArgument(): void`
`35`	`35`	`[`
`36`	`36`	`[`
`37`	`37`	`'Command "example-rule" does not define argument "undefined".',`
`38`		`- 37,`
	`38`	`+ 41,`
`39`	`39`	`],`
`40`	`40`	`]`
`41`	`41`	`);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function testGetArgument(): void`
`35`	`35`	`[`
`36`	`36`	`[`
`37`	`37`	`'Command "example-rule" does not define option "bbb".',`
`38`		`- 44,`
	`38`	`+ 48,`
`39`	`39`	`],`
`40`	`40`	`]`
`41`	`41`	`);`

Comments

(0)