Commit a222e65

committed

Merge branch 'rules' of git://github.com/mcfedr/phpstan-symfony into mcfedr-rules

2 parents 79c938c + f79eb89 commit a222e65Copy full SHA for a222e65

File tree

+18

-10

lines changed

+18

-10

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -37,6 +37,13 @@ If you don't want to use `phpstan/extension-installer`, include extension.neon i
`37`	`37`	`includes:`
`38`	`38`	`- vendor/phpstan/phpstan-symfony/extension.neon`
`39`	`39`	```
	`40`	`+`
	`41`	`+To perform framework-specific checks, include also this file:`
	`42`	`+`
	`43`	+```
	`44`	`+includes:`
	`45`	`+ - vendor/phpstan/phpstan-symfony/rules.neon`
	`46`	+```
`40`	`47`	`</details>`
`41`	`48`
`42`	`49`	`# Configuration`
`@@ -51,7 +58,6 @@ parameters:`
`51`	`58`	`container_xml_path: '%rootDir%/../../../var/cache/dev/srcApp_KernelDevDebugContainer.xml'`
`52`	`59`	```
`53`	`60`
`54`		`-`
`55`	`61`	`## Constant hassers`
`56`	`62`
`57`	`63`	Sometimes, when you are dealing with optional dependencies, the `::has()` methods can cause problems. For example, the following construct would complain that the condition is always either on or off, depending on whether you have the dependency for `service` installed:

Lines changed: 2 additions & 1 deletion

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,14 +11,6 @@ parametersSchema:`
`11`	`11`	`console_application_loader: schema(string(), nullable())`
`12`	`12`	`])`
`13`	`13`
`14`		`-rules:`
`15`		`- - PHPStan\Rules\Symfony\ContainerInterfacePrivateServiceRule`
`16`		`- - PHPStan\Rules\Symfony\ContainerInterfaceUnknownServiceRule`
`17`		`- - PHPStan\Rules\Symfony\UndefinedArgumentRule`
`18`		`- - PHPStan\Rules\Symfony\InvalidArgumentDefaultValueRule`
`19`		`- - PHPStan\Rules\Symfony\UndefinedOptionRule`
`20`		`- - PHPStan\Rules\Symfony\InvalidOptionDefaultValueRule`
`21`		`-`
`22`	`14`	`services:`
`23`	`15`	`# console resolver`
`24`	`16`	`-`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,8 @@`
	`1`	`+rules:`
	`2`	`+ - PHPStan\Rules\Symfony\ContainerInterfacePrivateServiceRule`
	`3`	`+ - PHPStan\Rules\Symfony\ContainerInterfaceUnknownServiceRule`
	`4`	`+ - PHPStan\Rules\Symfony\UndefinedArgumentRule`
	`5`	`+ - PHPStan\Rules\Symfony\InvalidArgumentDefaultValueRule`
	`6`	`+ - PHPStan\Rules\Symfony\UndefinedOptionRule`
	`7`	`+ - PHPStan\Rules\Symfony\InvalidOptionDefaultValueRule`
	`8`	`+`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public function testExtensionNeon(): void`
`28`	`28`	`$compiler->addExtension('parametersSchema', new ParametersSchemaExtension());`
`29`	`29`	`$compiler->addConfig(['parameters' => ['rootDir' => __DIR__]]);`
`30`	`30`	`$compiler->loadConfig(__DIR__ . '/../../extension.neon');`
	`31`	`+ $compiler->loadConfig(__DIR__ . '/../../rules.neon');`
`31`	`32`	`$compiler->loadConfig(__DIR__ . '/config.neon');`
`32`	`33`	`}, $key);`
`33`	`34`	`/** @var \Nette\DI\Container $container */`

Comments

(0)