Commit 6cac146

committed

getOption() can return int

1 parent a4d8502 commit 6cac146Copy full SHA for 6cac146

File tree

-9

lines changed

-9

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function processNode(Node $node, Scope $scope): array`
`66`	`66`
`67`	`67`	`// not an array`
`68`	`68`	`if (($mode & 8) !== 8) {`
`69`		`- $checkType = new UnionType([new StringType(), new NullType()]);`
	`69`	`+ $checkType = new UnionType([new StringType(), new IntegerType(), newNullType()]);`
`70`	`70`	`if (($mode & 4) === 4) { // https://symfony.com/doc/current/console/input.html#options-with-optional-arguments`
`71`	`71`	`$checkType = TypeCombinator::union($checkType, new ConstantBooleanType(false));`
`72`	`72`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,12 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method`
`67`	`67`	`if (!$option->acceptValue()) {`
`68`	`68`	`$optType = new BooleanType();`
`69`	`69`	`} else {`
`70`		`- $optType = TypeCombinator::union(new StringType(), new NullType());`
	`70`	`+ $optType = TypeCombinator::union(new StringType(), new IntegerType(), newNullType());`
`71`	`71`	`if ($option->isValueRequired() && ($option->isArray() \|\| $option->getDefault() !== null)) {`
`72`	`72`	`$optType = TypeCombinator::removeNull($optType);`
`73`	`73`	`}`
`74`	`74`	`if ($option->isArray()) {`
`75`		`- $optType = new ArrayType(new IntegerType(), $optType);`
	`75`	`+ $optType = new ArrayType(new IntegerType(), TypeCombinator::remove($optType, newIntegerType()));`
`76`	`76`	`}`
`77`	`77`	`$optType = TypeCombinator::union($optType, $scope->getTypeFromValue($option->getDefault()));`
`78`	`78`	`}`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,10 +24,6 @@ public function testGetArgument(): void`
`24`	`24`	`'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<int, string>\|null, array<int, int> given.',`
`25`	`25`	`29,`
`26`	`26`	`],`
`27`		`- [`
`28`		`- 'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects string\|false\|null, int given.',`
`29`		`- 30,`
`30`		`- ],`
`31`	`27`	`]`
`32`	`28`	`);`
`33`	`29`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,8 @@ public function testArgumentTypes(string $expression, string $type): void`
`24`	`24`	`public function argumentTypesProvider(): Iterator`
`25`	`25`	`{`
`26`	`26`	`yield ['$a', 'bool'];`
`27`		`- yield ['$b', 'string\|null'];`
`28`		`- yield ['$c', 'string\|null'];`
	`27`	`+ yield ['$b', 'int\|string\|null'];`
	`28`	`+ yield ['$c', 'int\|string\|null'];`
`29`	`29`	`yield ['$d', 'array<int, string\|null>'];`
`30`	`30`	`yield ['$e', 'array<int, string>'];`
`31`	`31`

Comments

(0)