Commit 012305d

committed

Request: Return Session instead of SessionInterface

1 parent 99a1dc9 commit 012305dCopy full SHA for 012305d

File tree

+11

-6

lines changed

stubs/Symfony/Component/HttpFoundation
- Request.stub
tests/Type/Symfony/data
- request_get_session.php
- request_get_session_null.php

+11

-6

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,4 +26,9 @@ class Request`
`26`	`26`	`*/`
`27`	`27`	`public $cookies;`
`28`	`28`
	`29`	`+ /**`
	`30`	`+ * @return \Symfony\Component\HttpFoundation\Session\Session`
	`31`	`+ */`
	`32`	`+ public function getSession(): SessionInterface;`
	`33`	`+`
`29`	`34`	`}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,14 @@`
`1`	`1`	`<?php declare(strict_types = 1);`
`2`	`2`
`3`		`-use Symfony\Component\HttpFoundation\Session\SessionInterface;`
	`3`	`+use Symfony\Component\HttpFoundation\Session\Session;`
`4`	`4`	`use function PHPStan\Testing\assertType;`
`5`	`5`
`6`	`6`	`/** @var \Symfony\Component\HttpFoundation\Request $request */`
`7`	`7`	`$request = doRequest();`
`8`	`8`
`9`	`9`	`$session1 = $request->getSession();`
`10`		`-assertType(SessionInterface::class, $request->getSession());`
	`10`	`+assertType(Session::class, $request->getSession());`
`11`	`11`
`12`	`12`	`if ($request->hasSession()) {`
`13`		`- assertType(SessionInterface::class, $request->getSession());`
	`13`	`+ assertType(Session::class, $request->getSession());`
`14`	`14`	`}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,14 @@`
`1`	`1`	`<?php declare(strict_types = 1);`
`2`	`2`
`3`		`-use Symfony\Component\HttpFoundation\Session\SessionInterface;`
	`3`	`+use Symfony\Component\HttpFoundation\Session\Session;`
`4`	`4`	`use function PHPStan\Testing\assertType;`
`5`	`5`
`6`	`6`	`/** @var \Symfony\Component\HttpFoundation\Request $request */`
`7`	`7`	`$request = doRequest();`
`8`	`8`
`9`	`9`	`$session1 = $request->getSession();`
`10`		`-assertType(SessionInterface::class . '\|null', $request->getSession());`
	`10`	`+assertType(Session::class . '\|null', $request->getSession());`
`11`	`11`
`12`	`12`	`if ($request->hasSession()) {`
`13`		`- assertType(SessionInterface::class, $request->getSession());`
	`13`	`+ assertType(Session::class, $request->getSession());`
`14`	`14`	`}`

Comments

(0)