Commit b564ca4

VincentLangletondrejmirtes

authored and

committed

Handle SimpleXMLElement in VariablePropertyFetchRule

1 parent daeec74 commit b564ca4Copy full SHA for b564ca4

File tree

+26

-2

lines changed

+26

-2

lines changed

Lines changed: 14 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`use PHPStan\Rules\Rule;`
`11`	`11`	`use PHPStan\Rules\RuleErrorBuilder;`
`12`	`12`	`use PHPStan\Type\VerbosityLevel;`
	`13`	`+use SimpleXMLElement;`
`13`	`14`	`use function sprintf;`
`14`	`15`
`15`	`16`	`/**`
`@@ -50,7 +51,11 @@ public function processNode(Node $node, Scope $scope): array`
`50`	`51`	`continue;`
`51`	`52`	`}`
`52`	`53`
`53`		`- if ($this->isUniversalObjectCrate($this->reflectionProvider->getClass($referencedClass))) {`
	`54`	`+ $classReflection = $this->reflectionProvider->getClass($referencedClass);`
	`55`	`+ if (`
	`56`	`+ $this->isUniversalObjectCrate($classReflection)`
	`57`	`+ \|\| $this->isSimpleXMLElement($classReflection)`
	`58`	`+ ) {`
`54`	`59`	`return [];`
`55`	`60`	`}`
`56`	`61`	`}`
`@@ -63,6 +68,14 @@ public function processNode(Node $node, Scope $scope): array`
`63`	`68`	`];`
`64`	`69`	`}`
`65`	`70`
	`71`	`+ private function isSimpleXMLElement(`
	`72`	`+ ClassReflection $classReflection`
	`73`	`+ ): bool`
	`74`	`+ {`
	`75`	`+ return $classReflection->getName() === SimpleXMLElement::class`
	`76`	`+ \|\| $classReflection->isSubclassOf(SimpleXMLElement::class);`
	`77`	`+ }`
	`78`	`+`
`66`	`79`	`private function isUniversalObjectCrate(`
`67`	`80`	`ClassReflection $classReflection`
`68`	`81`	`): bool`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ protected function getRule(): Rule`
`15`	`15`	`{`
`16`	`16`	`return new VariablePropertyFetchRule($this->createReflectionProvider(), [`
`17`	`17`	`'stdClass',`
`18`		`- 'SimpleXMLElement',`
`19`	`18`	`]);`
`20`	`19`	`}`
`21`	`20`
`@@ -29,4 +28,9 @@ public function testRule(): void`
`29`	`28`	`]);`
`30`	`29`	`}`
`31`	`30`
	`31`	`+ public function testBug243(): void`
	`32`	`+ {`
	`33`	`+ $this->analyse([__DIR__ . '/data/bug243.php'], []);`
	`34`	`+ }`
	`35`	`+`
`32`	`36`	`}`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,7 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+namespace Bug243;`
	`4`	`+`
	`5`	`+function test(\SimpleXMLElement $xml) {`
	`6`	`+ $xml->{'foo-bar'};`
	`7`	`+};`

Comments

(0)