Commit 361f75b

committed

OperandsInArithmeticAdditionRule - allow benevolent unions of arrays

1 parent 2ffa76a commit 361f75bCopy full SHA for 361f75b

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 1 deletion

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,8 @@`
`7`	`7`	`use PhpParser\Node\Expr\BinaryOp\Plus;`
`8`	`8`	`use PHPStan\Analyser\Scope;`
`9`	`9`	`use PHPStan\Rules\Rule;`
`10`		`-use PHPStan\Type\ArrayType;`
`11`		`-use PHPStan\Type\MixedType;`
`12`	`10`	`use PHPStan\Type\VerbosityLevel;`
	`11`	`+use function count;`
`13`	`12`	`use function sprintf;`
`14`	`13`
`15`	`14`	`class OperandsInArithmeticAdditionRule implements Rule`
`@@ -36,9 +35,7 @@ public function processNode(Node $node, Scope $scope): array`
`36`	`35`	`{`
`37`	`36`	`$leftType = $scope->getType($node->left);`
`38`	`37`	`$rightType = $scope->getType($node->right);`
`39`		`- $mixedArrayType = new ArrayType(new MixedType(), new MixedType());`
`40`		`-`
`41`		`- if ($mixedArrayType->isSuperTypeOf($leftType)->yes() && $mixedArrayType->isSuperTypeOf($rightType)->yes()) {`
	`38`	`+ if (count($leftType->getArrays()) > 0 && count($rightType->getArrays()) > 0) {`
`42`	`39`	`return [];`
`43`	`40`	`}`
`44`	`41`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -113,3 +113,7 @@ function (array $array, int $int, $mixed) {`
`113`	`113`	`/** @var numeric-string $numericString */`
`114`	`114`	`$numericString = doFoo();`
`115`	`115`	`$numericString + 1;`
	`116`	`+`
	`117`	`+function (\ReflectionClass $ref): void {`
	`118`	`+ print_r(class_parents($ref->getName()) + class_implements($ref->getName()));`
	`119`	`+};`

Comments

(0)