Commit 1f1358d

staabmondrejmirtes

authored and

committed

UselessCastRule: do cheaper check first

1 parent 73c5baa commit 1f1358dCopy full SHA for 1f1358d

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,12 +55,12 @@ public function processNode(Node $node, Scope $scope): array`
`55`	`55`	`return $ruleErrorBuilder;`
`56`	`56`	`}`
`57`	`57`
`58`		`- $expressionTypeWithoutPhpDoc = $scope->getNativeType($node->expr);`
`59`		`- if ($castType->isSuperTypeOf($expressionTypeWithoutPhpDoc)->yes()) {`
	`58`	`+ if (!$this->treatPhpDocTypesAsCertainTip) {`
`60`	`59`	`return $ruleErrorBuilder;`
`61`	`60`	`}`
`62`	`61`
`63`		`- if (!$this->treatPhpDocTypesAsCertainTip) {`
	`62`	`+ $expressionTypeWithoutPhpDoc = $scope->getNativeType($node->expr);`
	`63`	`+ if ($castType->isSuperTypeOf($expressionTypeWithoutPhpDoc)->yes()) {`
`64`	`64`	`return $ruleErrorBuilder;`
`65`	`65`	`}`
`66`	`66`

Comments

(0)