Commit 11b6403

staabmondrejmirtes

authored and

committed

Simplify tests in which treatPhpDocTypesAsCertain is always true

1 parent b043bd8 commit 11b6403Copy full SHA for 11b6403

File tree

-10

lines changed

-10

lines changed

Lines changed: 1 addition & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,28 +11,20 @@`
`11`	`11`	`class ArrayFilterStrictRuleTest extends RuleTestCase`
`12`	`12`	`{`
`13`	`13`
`14`		`- private bool $treatPhpDocTypesAsCertain;`
`15`		`-`
`16`	`14`	`private bool $checkNullables;`
`17`	`15`
`18`	`16`	`protected function getRule(): Rule`
`19`	`17`	`{`
`20`	`18`	`return new ArrayFilterStrictRule(`
`21`	`19`	`$this->createReflectionProvider(),`
`22`		`- $this->treatPhpDocTypesAsCertain,`
	`20`	`+ $this->shouldTreatPhpDocTypesAsCertain(),`
`23`	`21`	`$this->checkNullables,`
`24`	`22`	`true,`
`25`	`23`	`);`
`26`	`24`	`}`
`27`	`25`
`28`		`- protected function shouldTreatPhpDocTypesAsCertain(): bool`
`29`		`- {`
`30`		`- return $this->treatPhpDocTypesAsCertain;`
`31`		`- }`
`32`		`-`
`33`	`26`	`public function testRule(): void`
`34`	`27`	`{`
`35`		`- $this->treatPhpDocTypesAsCertain = true;`
`36`	`28`	`$this->checkNullables = true;`
`37`	`29`	`$this->analyse([__DIR__ . '/data/array-filter-strict.php'], [`
`38`	`30`	`[`
`@@ -60,7 +52,6 @@ public function testRule(): void`
`60`	`52`
`61`	`53`	`public function testRuleAllowMissingCallbackInSomeCases(): void`
`62`	`54`	`{`
`63`		`- $this->treatPhpDocTypesAsCertain = true;`
`64`	`55`	`$this->checkNullables = true;`
`65`	`56`	`$this->analyse([__DIR__ . '/data/array-filter-allow.php'], [`
`66`	`57`	`[`

Comments

(0)