Commit f158d5b

committed

Do not report nonexistent variable passed to by-ref parameter with checkImplicitMixed

1 parent 3447391 commit f158d5bCopy full SHA for f158d5b

File tree

+34

-1

lines changed

+34

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,11 @@ public function check(`
`313`	`313`
`314`	`314`	`if (`
`315`	`315`	`!$parameter->passedByReference()->createsNewVariable()`
`316`		`- \|\| (!$isBuiltin && $this->checkUnresolvableParameterTypes) // bleeding edge only`
	`316`	`+ \|\| (`
	`317`	`+ !$isBuiltin`
	`318`	`+ && $this->checkUnresolvableParameterTypes // bleeding edge only`
	`319`	`+ && !$argumentValueType instanceof ErrorType`
	`320`	`+ )`
`317`	`321`	`) {`
`318`	`322`	`$accepts = $this->ruleLevelHelper->acceptsWithReason($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());`
`319`	`323`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -849,4 +849,12 @@ public function testBug10872(): void`
`849`	`849`	`$this->analyse([__DIR__ . '/data/bug-10872.php'], []);`
`850`	`850`	`}`
`851`	`851`
	`852`	`+ public function testBug12015(): void`
	`853`	`+ {`
	`854`	`+ $this->checkThisOnly = false;`
	`855`	`+ $this->checkExplicitMixed = true;`
	`856`	`+ $this->checkImplicitMixed = true;`
	`857`	`+ $this->analyse([__DIR__ . '/data/bug-12015.php'], []);`
	`858`	`+ }`
	`859`	`+`
`852`	`860`	`}`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,21 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+namespace Bug12015;`
	`4`	`+`
	`5`	`+class HelloWorld`
	`6`	`+{`
	`7`	`+`
	`8`	`+ /**`
	`9`	`+ * @param-out int $ref`
	`10`	`+ */`
	`11`	`+ public static function passRef(?int &$ref): void`
	`12`	`+ {`
	`13`	`+ $ref = 1;`
	`14`	`+ }`
	`15`	`+}`
	`16`	`+`
	`17`	`+function test(): void`
	`18`	`+{`
	`19`	`+ HelloWorld::passRef($storeHere);`
	`20`	`+ echo $storeHere;`
	`21`	`+}`

Comments

(0)