Commit 5fbf086

committed

Treat Redis::connect as non-deterministic

1 parent 6f87293 commit 5fbf086Copy full SHA for 5fbf086

File tree

+35

-1

lines changed

+35

-1

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,10 @@`
`170`	`170`	`'DateTimeImmutable::getTimestamp' => ['hasSideEffects' => false],`
`171`	`171`	`'DateTimeImmutable::getTimezone' => ['hasSideEffects' => false],`
`172`	`172`
	`173`	`+ // affects isConnected()`
	`174`	`+ 'Redis::connect' => ['hasSideEffects' => true],`
	`175`	`+ 'Redis::pconnect' => ['hasSideEffects' => true],`
	`176`	`+`
`173`	`177`	`'SplDoublyLinkedList::pop' => ['hasSideEffects' => true],`
`174`	`178`	`'SplDoublyLinkedList::shift' => ['hasSideEffects' => true],`
`175`	`179`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -452,6 +452,8 @@`
`452`	`452`	`'NumberFormatter::getPattern' => ['hasSideEffects' => false],`
`453`	`453`	`'NumberFormatter::getSymbol' => ['hasSideEffects' => false],`
`454`	`454`	`'NumberFormatter::getTextAttribute' => ['hasSideEffects' => false],`
	`455`	`+ 'Redis::connect' => ['hasSideEffects' => true],`
	`456`	`+ 'Redis::pconnect' => ['hasSideEffects' => true],`
`455`	`457`	`'ReflectionAttribute::getArguments' => ['hasSideEffects' => false],`
`456`	`458`	`'ReflectionAttribute::getName' => ['hasSideEffects' => false],`
`457`	`459`	`'ReflectionAttribute::getTarget' => ['hasSideEffects' => false],`
`@@ -1621,4 +1623,4 @@`
`1621`	`1623`	`'zlib_encode' => ['hasSideEffects' => false],`
`1622`	`1624`	`'zlib_get_coding_type' => ['hasSideEffects' => false],`
`1623`	`1625`
`1624`		`-];`
	`1626`	`+];`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -106,4 +106,10 @@ public function testBug13384bOff(): void`
`106`	`106`	`$this->analyse([__DIR__ . '/data/bug-13384b.php'], []);`
`107`	`107`	`}`
`108`	`108`
	`109`	`+ public function testBugPR4318()`
	`110`	`+ {`
	`111`	`+ $this->reportTooWideBool = true;`
	`112`	`+ $this->analyse([__DIR__ . '/data/bug-pr-4318.php'], []);`
	`113`	`+ }`
	`114`	`+`
`109`	`115`	`}`

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,22 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+namespace BugPR4318;`
	`4`	`+`
	`5`	`+class Client`
	`6`	`+{`
	`7`	`+ private bool $isConnected = false;`
	`8`	`+`
	`9`	`+ public function connect(): void`
	`10`	`+ {`
	`11`	`+ $driver = new \Redis();`
	`12`	`+`
	`13`	`+ if ($driver->isConnected()) {`
	`14`	`+ return;`
	`15`	`+ }`
	`16`	`+`
	`17`	`+ $driver->connect('');`
	`18`	`+ $this->isConnected = $driver->isConnected();`
	`19`	`+ echo $this->isConnected;`
	`20`	`+ }`
	`21`	`+`
	`22`	`+}`

Comments

(0)