Commit 5a39902

authored

Fix Promoted vs. regular property inconsistency with generics

1 parent cd6b3fd commit 5a39902Copy full SHA for 5a39902

File tree

+48

-2

lines changed

+48

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -651,7 +651,7 @@ private function processStmtNode(`
`651`	`651`	`$throwPoints = [];`
`652`	`652`	`$impurePoints = [];`
`653`	`653`	`$this->processAttributeGroups($stmt, $stmt->attrGroups, $scope, $nodeCallback);`
`654`		`- [$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);`
	`654`	`+ [$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, $isReadOnly, $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);`
`655`	`655`
`656`	`656`	`foreach ($stmt->params as $param) {`
`657`	`657`	`$this->processParamNode($stmt, $param, $scope, $nodeCallback);`
`@@ -718,7 +718,7 @@ private function processStmtNode(`
`718`	`718`	`true,`
`719`	`719`	`$isFromTrait,`
`720`	`720`	`$param,`
`721`		`- false,`
	`721`	`+ $isReadOnly,`
`722`	`722`	`$scope->isInTrait(),`
`723`	`723`	`$classReflection->isReadOnly(),`
`724`	`724`	`false,`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -132,4 +132,9 @@ public function testBug9153(): void`
`132`	`132`	`$this->analyse([__DIR__ . '/data/bug-9153.php'], []);`
`133`	`133`	`}`
`134`	`134`
	`135`	`+ public function testBug13049(): void`
	`136`	`+ {`
	`137`	`+ $this->analyse([__DIR__ . '/data/bug-13049.php'], []);`
	`138`	`+ }`
	`139`	`+`
`135`	`140`	`}`

Lines changed: 41 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,41 @@`
	`1`	`+<?php // lint >= 8.0`
	`2`	`+`
	`3`	`+declare(strict_types = 1);`
	`4`	`+`
	`5`	`+namespace Bug13049;`
	`6`	`+`
	`7`	`+/**`
	`8`	`+ * @template-covariant Value of string\|list<string>`
	`9`	`+ *`
	`10`	`+ * @immutable`
	`11`	`+ */`
	`12`	`+final class LanguageProperty`
	`13`	`+{`
	`14`	`+`
	`15`	`+ /** @var Value */`
	`16`	`+ public $value;`
	`17`	`+`
	`18`	`+ /**`
	`19`	`+ * @param Value $value`
	`20`	`+ */`
	`21`	`+ public function __construct($value)`
	`22`	`+ {`
	`23`	`+ $this->value = $value;`
	`24`	`+ }`
	`25`	`+}`
	`26`	`+`
	`27`	`+/**`
	`28`	`+ * @template-covariant Value of string\|list<string>`
	`29`	`+ *`
	`30`	`+ * @immutable`
	`31`	`+ */`
	`32`	`+final class LanguageProperty2`
	`33`	`+{`
	`34`	`+ /**`
	`35`	`+ * @param Value $value`
	`36`	`+ */`
	`37`	`+ public function __construct(public $value)`
	`38`	`+ {`
	`39`	`+ $this->value = $value;`
	`40`	`+ }`
	`41`	`+}`

Comments

(0)