Commit 4782556

committed

fix: dynamic variable error on isset

1 parent cb8cead commit 4782556Copy full SHA for 4782556

File tree

+21

-0

lines changed

+21

-0

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,14 @@ public function __construct(`
`41`	`41`	`*/`
`42`	`42`	`public function check(Expr $expr, Scope $scope, string $operatorDescription, string $identifier, callable $typeMessageCallback, ?IdentifierRuleError $error = null): ?IdentifierRuleError`
`43`	`43`	`{`
	`44`	`+ // [FIX] Ignore isset($$foo): dynamic variable`
	`45`	`+ if (`
	`46`	`+ $expr instanceof Node\Expr\Variable &&`
	`47`	`+ $expr->name instanceof Node\Expr\Variable`
	`48`	`+ ) {`
	`49`	`+ return null;`
	`50`	`+ }`
	`51`	`+`
`44`	`52`	`// mirrored in PHPStan\Analyser\MutatingScope::issetCheck()`
`45`	`53`	`if ($expr instanceof Node\Expr\Variable && is_string($expr->name)) {`
`46`	`54`	`$hasVariable = $scope->hasVariableType($expr->name);`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -485,4 +485,10 @@ public function testIssetAfterRememberedConstructor(): void`
`485`	`485`	`]);`
`486`	`486`	`}`
`487`	`487`
	`488`	`+ public function testDynamicVariable(): void`
	`489`	`+ {`
	`490`	`+ $this->treatPhpDocTypesAsCertain = true;`
	`491`	`+`
	`492`	`+ $this->analyse([__DIR__ . '/data/dynamic-variable.php'], []);`
	`493`	`+ }`
`488`	`494`	`}`

Lines changed: 7 additions & 0 deletions

Comments

(0)