Commit e32ac65

staabmondrejmirtes

authored and

committed

Support assertNotEquals in AssertEqualsIsDiscouragedRule

1 parent 2cedfb7 commit e32ac65Copy full SHA for e32ac65

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`use PHPStan\Type\GeneralizePrecision;`
`11`	`11`	`use PHPStan\Type\TypeCombinator;`
`12`	`12`	`use function count;`
	`13`	`+use function in_array;`
`13`	`14`	`use function strtolower;`
`14`	`15`
`15`	`16`	`/**`
`@@ -32,7 +33,10 @@ public function processNode(Node $node, Scope $scope): array`
`32`	`33`	`if (count($node->getArgs()) < 2) {`
`33`	`34`	`return [];`
`34`	`35`	`}`
`35`		`- if (!$node->name instanceof Node\Identifier \|\| strtolower($node->name->name) !== 'assertequals') {`
	`36`	`+ if (`
	`37`	`+ !$node->name instanceof Node\Identifier`
	`38`	`+ \|\| !in_array(strtolower($node->name->name), ['assertequals', 'assertnotequals'], true)`
	`39`	`+ ) {`
`36`	`40`	`return [];`
`37`	`41`	`}`
`38`	`42`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@ public function testRule(): void`
`27`	`27`	`[self::ERROR_MESSAGE, 29],`
`28`	`28`	`[self::ERROR_MESSAGE, 30],`
`29`	`29`	`[self::ERROR_MESSAGE, 32],`
	`30`	`+ [self::ERROR_MESSAGE, 37],`
	`31`	`+ [self::ERROR_MESSAGE, 38],`
	`32`	`+ [self::ERROR_MESSAGE, 39],`
`30`	`33`	`]);`
`31`	`34`	`}`
`32`	`35`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,11 @@ public function dummyTest(string $string, int $integer, bool $boolean, float $fl`
`33`	`33`	`$this->assertEquals([], []);`
`34`	`34`	`$this->assertEquals(new Exception(), new Exception());`
`35`	`35`	`static::assertEquals(new Exception(), new Exception());`
	`36`	`+`
	`37`	`+ $this->assertNotEquals($string, $string);`
	`38`	`+ $this->assertNotEquals($integer, $integer);`
	`39`	`+ $this->assertNotEquals($boolean, $boolean);`
	`40`	`+ $this->assertNotSame(5, $integer);`
	`41`	`+ static::assertNotSame(5, $integer);`
`36`	`42`	`}`
`37`	`43`	`}`

Comments

(0)